Enable new uploader in desktop

[oscartbeaumont]

This should enable the feature flag in production buildes by default instead of us needing to ask the user to enable it.

Summary by CodeRabbit

• New Features
  • The new uploader is now enabled by default across all builds, delivering the updated upload experience out of the box.
  • New installations and profiles without a prior preference will start with the new uploader enabled; existing user selections remain unchanged.
  • This ensures a consistent experience across environments and makes it easier for users to access the latest uploading flow.

[coderabbitai]

Walkthrough

The default for enable_new_uploader in GeneralSettingsStore was changed to always true, removing the prior build-flag conditional based on debug_assertions. No other logic or public interfaces were modified.

Changes

Cohort / File(s)	Summary
Desktop general settings default apps/desktop/src-tauri/src/general_settings.rs	Set enable_new_uploader default to true, removing the debug_assertions-dependent conditional in Default implementation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

A switch flips on in twilight code,
New uploader hops the daily road.
No flags to check, no branch to choose,
Just carrot-bright defaults to use.
I thump approval, ears held high—
Ship it swift, and let it fly! 🥕🐇

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title directly and concisely describes the primary change, enabling the new uploader feature in the desktop application. It aligns precisely with the PR’s objective of turning on this feature by default without extraneous details or vague wording. This clarity allows a reviewer to understand the core intent at a glance.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch enable-new-uploader

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4ed9088 and 039ab95.

📒 Files selected for processing (1)

• apps/desktop/src-tauri/src/general_settings.rs (1 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

**/*.{ts,tsx,js,jsx,rs}

📄 CodeRabbit inference engine (CLAUDE.md)

Do not add inline, block, or docstring comments in any language; code must be self-explanatory

Files:

• apps/desktop/src-tauri/src/general_settings.rs

**/*.rs

📄 CodeRabbit inference engine (AGENTS.md)

**/*.rs: Format Rust code using rustfmt and ensure all Rust code passes workspace-level clippy lints.
Rust modules should be named with snake_case, and crate directories should be in kebab-case.

Files:

• apps/desktop/src-tauri/src/general_settings.rs

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: Build Desktop (aarch64-apple-darwin, macos-latest)
• GitHub Check: Build Desktop (x86_64-pc-windows-msvc, windows-latest)
• GitHub Check: Analyze (rust)

🔇 Additional comments (1)

apps/desktop/src-tauri/src/general_settings.rs (1)

113-115: Verify production readiness of auto-opted new uploader. Existing production users will now load with enable_new_uploader = true by default. Confirm end-to-end tests cover the new uploader flows, update docs/release notes for this behavioral change, and plan any phased rollout or override fallback.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Walkthrough

The default value for enable_new_uploader was changed to always return true via default_enable_new_uploader, removing the previous debug-only conditional. No public APIs or types were modified.

Changes

Cohort / File(s)	Summary
General settings default toggle apps/desktop/src-tauri/src/general_settings.rs	Changed default_enable_new_uploader to unconditionally return true, removing cfg!(debug_assertions) gating; no API/signature changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I flip a tiny switch—now always on,
The uploader hums from dusk till dawn.
No more debug peekaboo play,
It’s true by default, come what may.
Thump-thump, I merge with gleeful cheer—
A rabbit approves: the path is clear! 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title succinctly reflects the primary change of always enabling the new uploader feature in the desktop application, matching the PR’s intention to remove debug gating and enable it by default.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch enable-new-uploader

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4ed9088 and 039ab95.

📒 Files selected for processing (1)

• apps/desktop/src-tauri/src/general_settings.rs (1 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

**/*.{ts,tsx,js,jsx,rs}

📄 CodeRabbit inference engine (CLAUDE.md)

Do not add inline, block, or docstring comments in any language; code must be self-explanatory

Files:

• apps/desktop/src-tauri/src/general_settings.rs

**/*.rs

📄 CodeRabbit inference engine (AGENTS.md)

**/*.rs: Format Rust code using rustfmt and ensure all Rust code passes workspace-level clippy lints.
Rust modules should be named with snake_case, and crate directories should be in kebab-case.

Files:

• apps/desktop/src-tauri/src/general_settings.rs

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: Build Desktop (aarch64-apple-darwin, macos-latest)
• GitHub Check: Build Desktop (x86_64-pc-windows-msvc, windows-latest)
• GitHub Check: Analyze (rust)

🔇 Additional comments (1)

apps/desktop/src-tauri/src/general_settings.rs (1)

113-115: Approve default enablement; verify production readiness
The new uploader is enabled by default and preserves existing user preferences. Confirm complete production testing (error handling, retries, monitoring). Once stable, add a deprecation comment for this flag.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}