improvement: share page google login support

[ameer2468]

Summary by CodeRabbit

• New Features
  • Added “Continue with Google” option to the share-page auth overlay, alongside email sign-in, returning users to the video after login.
• Bug Fixes
  • Dashboard navbar now displays the organization’s custom domain only when verified; otherwise shows “No custom domain set.”
• Style
  • Minor spacing improvement in the login form for better readability.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Updates include gating org custom domain display on verification in the dashboard navbar, a minor spacing tweak in the org login form, and adding a Google sign-in path with analytics and videoId-aware callback to the share-page auth overlay.

Changes

Cohort / File(s)	Summary
Navbar domain verification gate apps/web/app/(org)/dashboard/_components/Navbar/Items.tsx	Show custom domain only when both customDomain and domainVerified are truthy; otherwise display "No custom domain set". Rendering condition adjusted; no link targets changed.
Org login form styling apps/web/app/(org)/login/form.tsx	Added mb-2 to a paragraph in NormalLogin for increased bottom margin; no logic changes.
Share-page auth: Google sign-in apps/web/app/s/[videoId]/_components/AuthOverlay.tsx	Added useParams to read videoId, trackEvent for analytics, and a Google Sign-In button calling signIn("google", { redirect: false, callbackUrl: "/s/{videoId}" }). Added UI separator and button group; email sign-in unchanged.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor U as User
  participant AO as AuthOverlay StepOne
  participant A as Analytics (trackEvent)
  participant NA as Auth (signIn "google")
  participant App as App Router

  U->>AO: Click "Login with Google"
  AO->>A: trackEvent("auth_google_click", { videoId })
  AO->>AO: setLoading(true)
  AO->>NA: signIn("google", { redirect: false, callbackUrl: "/s/{videoId}" })
  NA-->>AO: Promise resolved
  AO->>AO: setLoading(false)
  AO->>App: Navigate to callbackUrl (/s/{videoId})
  note over AO,App: Email flow remains available and unchanged

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• improvements: mask as read when opening notifications, show custom domain, and more #1042 — Adjusts organization custom domain display logic in the same navbar component; closely aligned change.
• feat: Add signup page and update navbar #1012 — Modifies the same org login form file with presentational tweaks; similar scope.

Poem

A bunny taps the keys with cheer,
“Now Google gets you quickly here!”
A verified domain on display,
A margin tweak to clear the way.
Hop, track, sign in—swift and bright—
/s/video lands you right.
Thump-thump, shipped tonight! 🐇✨

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch login-with-google-support

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1e13d80 and cb9b045.

📒 Files selected for processing (3)

• apps/web/app/(org)/dashboard/_components/Navbar/Items.tsx (1 hunks)
• apps/web/app/(org)/login/form.tsx (1 hunks)
• apps/web/app/s/[videoId]/_components/AuthOverlay.tsx (3 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}