fix: adjust into to model 4 show custom order #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Bulletdev
commented
Oct 12, 2025
Bulletdev
commented
- Adicionado scope ordered_by_role no model Player (app/models/player.rb:41-52)
- Usa CASE WHEN do SQL para ordenar na sequência correta: top → jungle → mid → adc → support
- Atualizado PlayersController (app/controllers/api/v1/players_controller.rb:18)
- Substituiu .order(:role, :summoner_name) por .ordered_by_role.order(:summoner_name)
- Agora ordena primeiro por posição (na ordem correta) e depois pelo nome do jogador
- Atualizado DashboardController (app/controllers/api/v1/dashboard_controller.rb:113)
- O by_role agora também respeita a ordem correta das posições
1. Adicionado scope ordered_by_role no model Player (app/models/player.rb:41-52) - Usa CASE WHEN do SQL para ordenar na sequência correta: top → jungle → mid → adc → support 2. Atualizado PlayersController (app/controllers/api/v1/players_controller.rb:18) - Substituiu .order(:role, :summoner_name) por .ordered_by_role.order(:summoner_name) - Agora ordena primeiro por posição (na ordem correta) e depois pelo nome do jogador 3. Atualizado DashboardController (app/controllers/api/v1/dashboard_controller.rb:113) - O by_role agora também respeita a ordem correta das posições
- Os workflows tentavam comentar em PRs/Issues usando github.rest.issues.createComment() - Mas não tinham as permissões pull-requests: write e issues: write configuradas - Por padrão, o GitHub Actions tem permissões restritas para segurança
Contributor
🔒 Brakeman Security Scan
✅ No high confidence issues found. |
Contributor
📦 Dependency Security Check✅ No known vulnerabilities found. View Report |
Contributor
🔍 Semgrep Static Analysis
|
Contributor
🔐 Security Scan Summary
✅ All security checks passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.