This repository was archived by the owner on Mar 20, 2023. It is now read-only.
Merged
Conversation
Collaborator
pramodk
commented
Aug 18, 2020
- add svclmp.mod mod file from NEURON
- update registeration callbacks
- expose at_time in the header file
- add svclmp.mod mod file from NEURON - update registeration callbacks - expose at_time in the header file
nrnhines
approved these changes
Aug 18, 2020
Collaborator
nrnhines
left a comment
There was a problem hiding this comment.
This seem basically sound. I.e at_time already has an implementation. Also after_cvode likely emits the correct code (just puts the call to the function in the nrn_solve function) and if not I can activate the proper code in mod2c.
Collaborator
Author
|
NMODL needs to handle |
Contributor
|
please retest |
Contributor
|
Given the recent work done by @iomaganaris on at_time, I think this PR can be merged too right? |
Collaborator
Author
|
Yes but nmodl submodule needs to be updated in coreneuron repo. |
Collaborator
Author
I don't remember how to expose "annotate" function for ISPC but @ohm314 or @iomaganaris might remember better. |
pramodk
commented
Oct 9, 2020
iomaganaris
approved these changes
Oct 9, 2020
Collaborator
Author
|
Thanks @iomaganaris for all fixes with ISPC! |
pramodk
added a commit
to neuronsimulator/nrn
that referenced
this pull request
Nov 2, 2022
* Add SEClamp support in CoreNEURON - add svclmp.mod mod file from NEURON - update registeration callbacks - expose at_time in the header file * Fixed compilation issue for GPU with at_time and updated NMODL commit * Added definition of at_time in nrnoc_ml.ispc * Small fix for at_time declaration outside ispc Co-authored-by: Ioannis Magkanaris <iomagkanaris@gmail.com> CoreNEURON Repo SHA: BlueBrain/CoreNeuron@483f9d9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.