chore: add test for decoding overlapping keys with flatten#21
Merged
bitgopatmcl merged 1 commit intoBitGo:masterfrom Mar 30, 2022
bitgopatmcl:overlapping-decode-test
Merged
chore: add test for decoding overlapping keys with flatten#21bitgopatmcl merged 1 commit intoBitGo:masterfrom bitgopatmcl:overlapping-decode-test
bitgopatmcl merged 1 commit intoBitGo:masterfrom
bitgopatmcl:overlapping-decode-test
Conversation
Although it is undefined behavior to define a `flatten` codec with overlapping keys, the actual codec needs to handle arbitrary input which might have them. This commit adds a test for this, and fortunately the existing code passes.
ericcrosson-bitgo
approved these changes
Mar 30, 2022
Contributor
ericcrosson-bitgo
left a comment
ericcrosson-bitgo
left a comment
There was a problem hiding this comment.
Tests for sanity without explicitly defining behavior, 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although it is undefined behavior to define a
flattencodec withoverlapping keys, the actual codec needs to handle arbitrary input which
might have them. This commit adds a test for this, and fortunately the
existing code passes.