Skip to content

fix: coinName fix in token config#8286

Merged
rohitsaw115 merged 1 commit intomasterfrom
config-fix
Mar 13, 2026
Merged

fix: coinName fix in token config#8286
rohitsaw115 merged 1 commit intomasterfrom
config-fix

Conversation

@rohitsaw115
Copy link
Contributor

@rohitsaw115 rohitsaw115 commented Mar 12, 2026

ticket: cecho-125

Replace hardcoded coin.name.split(':')[0] base coin derivation in getEthLikeTokenConfig and getEthLikeERC721TokenConfig with coins.coinNameFromChainId(network.chainId), falling back to the split logic for backward compatibility
Fixes token registration for coins like hbarevm:tmt where the token name prefix doesn't match the expected testnet base coin name (e.g., hbarevm:tmt is a testnet token but name.split(':')[0] returns hbarevm instead of thbarevm)

@rohitsaw115 rohitsaw115 marked this pull request as ready for review March 12, 2026 15:55
@rohitsaw115 rohitsaw115 requested a review from a team as a code owner March 12, 2026 15:55
@rohitsaw115 rohitsaw115 changed the title fix: tokenName fix in config fix: coinName fix in token config Mar 12, 2026
Copy link
Contributor

@nayandas190 nayandas190 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rohitsaw115 rohitsaw115 marked this pull request as draft March 12, 2026 16:31
@rohitsaw115 rohitsaw115 marked this pull request as ready for review March 13, 2026 04:09
@rohitsaw115 rohitsaw115 merged commit c7d4e82 into master Mar 13, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants