feat(abstract-utxo): modernize test infrastructure#8285
Merged
OttoAllmendinger merged 2 commits intomasterfrom Mar 13, 2026
Merged
feat(abstract-utxo): modernize test infrastructure#8285OttoAllmendinger merged 2 commits intomasterfrom
OttoAllmendinger merged 2 commits intomasterfrom
Conversation
OttoAllmendinger
force-pushed
the
BTC-2768.remove-shouldjs
branch
2 times, most recently
from
72aaa50 to
47dc824
Compare
Update fmt script to use the same file pattern as check-fmt for consistency in formatting operations. Co-authored-by: llm-git <llm-git@ttll.de> Issue: BTC-2768
OttoAllmendinger
force-pushed
the
BTC-2768.remove-shouldjs
branch
from
47dc824 to
8dbae2d
Compare
Replace shouldjs assertions with Node.js native assert/strict throughout the abstract-utxo module test suite. This modernizes testing infrastructure and eliminates a deprecated dependency. Main changes: - Switch to node:assert/strict for all assertions - Add helper functions: `assertHasProperty`, `assertContains`, `assertEqualJSON` - Add `isPsbt` utility function for checking PSBT magic bytes - Update Sinon assertion syntax to use `sinon.assert.*` methods - Simplify assertion patterns across unit and integration tests Issue: BTC-2768 Co-authored-by: llm-git <llm-git@ttll.de>
OttoAllmendinger
force-pushed
the
BTC-2768.remove-shouldjs
branch
from
8dbae2d to
c6d44f2
Compare
OttoAllmendinger
changed the title
davidkaplanbitgo
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace shouldjs assertions with Node.js native assert/strict
throughout the abstract-utxo module test suite. This modernizes
testing infrastructure and eliminates a deprecated dependency.
Main changes:
assertHasProperty,assertContains,assertEqualJSONsinon.assert.*methodsoperations
Issue: BTC-2768