You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
This rolls minimum Dart SDK to the bundled with Flutter's latest stable version. Also, bumps pedantic and octo_image to latest versions. The update of octo_image is required for placeholders to not be wrongly placed.
💥 Does this PR introduce a breaking change?
From octo_image:
[0.3.0] - 2020-09-07
Fixed bug when fitting placeholders or error widgets.
BREAKING: Doesn't automatically center placeholders and error widgets anymore.
Which analyzer change do you think helps with #463?
Btw, it makes it easier to review if you make a PR per proposed change.
The update of octo_image is a no-brainer for me, but I have to think about the changes proposed with the analyzer for example.
As pub analyzer may complain that pedantic was not using the latest available version, I updated it and fixed the new warnings. I removed the rules from analysis_options.yaml because I think they're already included by including pedantic rules (if I removed one that was not included in pedantic, please tell me). Also, added 5961d95#diff-d62227308ce5fdb544ee6b0a8b157a69R18 which may help with pub's error as per flutter/plugins#2658
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
This rolls minimum Dart SDK to the bundled with Flutter's latest stable version. Also, bumps
pedanticandocto_imageto latest versions. The update ofocto_imageis required for placeholders to not be wrongly placed.💥 Does this PR introduce a breaking change?
From
octo_image:🤔 Checklist before submitting