Skip to content

Tkinter standardised approach#203

Merged
jamesramsden-bh merged 37 commits intodevelopfrom
Python_Toolkit-#202-Tkiner-UI-BHoM-Standardisation
Mar 10, 2026
Merged

Tkinter standardised approach#203
jamesramsden-bh merged 37 commits intodevelopfrom
Python_Toolkit-#202-Tkiner-UI-BHoM-Standardisation

Conversation

@Felix-Mallinder
Copy link
Contributor

@Felix-Mallinder Felix-Mallinder commented Feb 24, 2026

NOTE: Depends on

Issues addressed by this PR

Closes #202

Set up of BHoM standard approach for tkinter UIs

Test files

Can test by running any of the windows or widget objects - each has an example usage method in the file

Test script added to the test folder

Changelog

  • Set of scripts / methods developed in python_toolkit.bhom_tkinter for a modular approach to tkinter usage in dependant bhom toolkits.
  • BHoMBaseWindow has been established as a base object for all tkinter UI tools to inherit from, this handles base attributes such as styling.
  • bhom_tkinter.windows contains a series of pre-produced window objects, for direct use, including loading windows, warning windows etc.
  • bhom_tkinter.widgets includes a series of widgets to be used when building up a UI. these widgets inherit from BHoMBaseWidget for handling of get, set, packing & build protocols
  • .tcl sheets have been set for bhom styling, in dark and light mode. widgets use bhom logos and icons

Additional comments

@Felix-Mallinder Felix-Mallinder self-assigned this Feb 24, 2026
@Felix-Mallinder Felix-Mallinder added the type:feature New capability or enhancement label Feb 24, 2026
@Felix-Mallinder Felix-Mallinder linked an issue Feb 24, 2026 that may be closed by this pull request
@Felix-Mallinder Felix-Mallinder added the status:WIP PR in progress and still in draft, not ready for formal review label Feb 25, 2026
Copy link
Contributor

@Tom-Kingstone Tom-Kingstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good code wise on first cursory pass except a few comments, Will test when changes stop coming through.

@Felix-Mallinder Felix-Mallinder removed the status:WIP PR in progress and still in draft, not ready for formal review label Mar 4, 2026
Tom-Kingstone
Tom-Kingstone previously approved these changes Mar 9, 2026
Copy link
Contributor

@Tom-Kingstone Tom-Kingstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All is good after changes, tested the windows and widgets which look good and appear to function as expected.

@Tom-Kingstone
Copy link
Contributor

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 9, 2026

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@Tom-Kingstone
Copy link
Contributor

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 9, 2026

@Tom-Kingstone to confirm, the following actions are now queued:

  • check copyright-compliance

@Tom-Kingstone
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 9, 2026

@Tom-Kingstone to confirm, the following actions are now queued:

  • check ready-to-merge

Tom-Kingstone
Tom-Kingstone previously approved these changes Mar 10, 2026
Copy link
Contributor

@Tom-Kingstone Tom-Kingstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as before, I am not the decider on colour though so ask @jamesramsden-bh

@jamesramsden-bh
Copy link
Contributor

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 10, 2026

@jamesramsden-bh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link
Contributor

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have revised and discussed some styling structure with Felix, happy to merge

@Felix-Mallinder
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 10, 2026

@Felix-Mallinder to confirm, the following actions are now queued:

  • check ready-to-merge

@jamesramsden-bh
Copy link
Contributor

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 10, 2026

@jamesramsden-bh to confirm, the following actions are now queued:

  • check copyright-compliance

@jamesramsden-bh jamesramsden-bh merged commit 12843dc into develop Mar 10, 2026
10 checks passed
@jamesramsden-bh jamesramsden-bh deleted the Python_Toolkit-#202-Tkiner-UI-BHoM-Standardisation branch March 10, 2026 14:41
@BHoMBot BHoMBot mentioned this pull request Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:feature New capability or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tkinter UI BHoM standardisation

3 participants