-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[Core] Revert #23514: Rename entry script az.ps1 to azps.ps1
#24015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Users are able to use azpwsh.ps1 on demand. |
chasewilson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a problem with leaving it az.ps1? Is the customer able to specify their entry script by the extension?
Yes. If we don't rename
They can. |
az.ps1 to azpwsh.ps1az.ps1 to azpwsh.ps1
az.ps1 to azpwsh.ps1az.ps1 to azps.ps1
Description
#23514 added
az.ps1so that when Azure CLI is invoked in PowerShell,az.ps1is called instead ofaz.cmd.However, this change introduced 5 new issues:
Arguments
$mylistto Azure CLI #23797: PowerShell array$mylistis splatted when calling.cmd, but not when calling.ps1. Instead, the array is concatenated as a single string.--stops working in PowerShell since 2.40.0 #24034: PowerShell doesn't include--in$args--%stops working since Azure CLI 2.40.0 #24114:--%only works for native executable, but not.ps1script.stdin.ps1, PowerShell doesn't automatically connectstdinto pipeline.Exit code
pwsh.execalling.ps1calling.exeShell interaction
azcan't be invoked byStart-Processsince 2.40.0 #24005:.cmdcan be invoked byStart-Process, but.ps1cannot.This PR reverts the change by renaming
az.ps1toazps.ps1so that users can still use the.ps1entry script if they want, but by default, when callingaz,az.cmdwill be called as before.We will work with PowerShell team to see how to fix these issues.