Skip to content

[Modules] Added azureMonitorProfile to allow us to enable the Prometheus collector#4331

Merged
AlexanderSehr merged 1 commit intomainfrom
users/alsehr/managedClusterMetricProfile
Dec 6, 2023
Merged

[Modules] Added azureMonitorProfile to allow us to enable the Prometheus collector#4331
AlexanderSehr merged 1 commit intomainfrom
users/alsehr/managedClusterMetricProfile

Conversation

@AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Dec 3, 2023

Based on #4329
cc: @aadev1, @JPEasier

AVM ref: Azure/bicep-registry-modules#665

Description

Added azureMonitorProfile to allow us to enable the Prometheus collector and kube state metrics for prometheus addon profile for the container service cluster

Update azure/main.test.bicep and example in readme to test enabling Prometheus collector

This change will allow enabling the Prometheus collector and kube state metrics for prometheus addon profile for the container service cluster by adding the settings required to theazureMonitorProfile as per the 'Microsoft.ContainerService/managedClusters' documentation. See link below:

https://learn.microsoft.com/en-us/azure/templates/microsoft.containerservice/2023-07-02-preview/managedclusters?pivots=deployment-language-bicep#managedclusterazuremonitorprofilemetrics

Pipeline
ContainerService - ManagedClusters

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] modules category: modules enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants