Skip to content

[CI environment] Add nameprefix to rg test names#4038

Closed
eriqua wants to merge 1 commit intomainfrom
users/eriqua/rg-test-name
Closed

[CI environment] Add nameprefix to rg test names#4038
eriqua wants to merge 1 commit intomainfrom
users/eriqua/rg-test-name

Conversation

@eriqua
Copy link
Contributor

@eriqua eriqua commented Oct 1, 2023

Description

Add nameprefix to rg test names, aligning with avm pbr names

Pipeline references

Pipeline
DesktopVirtualization - ApplicationGroups

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@eriqua eriqua added [cat] modules category: modules [cat] testing category: testing labels Oct 1, 2023
@eriqua eriqua requested a review from a team as a code owner October 1, 2023 13:44
@AlexanderSehr
Copy link
Contributor

@eriqua, I believe we have a few cases where a name prefix doesn't exist (by design). Once I'm back at my laptop, I can run a quick test by compiling all test cases in memory

@eriqua
Copy link
Contributor Author

eriqua commented Oct 1, 2023

@eriqua, I believe we have a few cases where a name prefix doesn't exist (by design). Once I'm back at my laptop, I can run a quick test by compiling all test cases in memory

In that case we'd probably need to add it wherever an RG is created as part of the dependencies.

Copy link
Contributor

@AlexanderSehr AlexanderSehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noteworthy warnings/errors

  • ERROR: C:\dev\ip\Azure-ResourceModules\ResourceModules\modules\managed-identity\user-assigned-identity.test\min\main.test.bicep(9,41) : Error BCP057: The name "namePrefix" does not exist in the current context.
  • WARNING: C:\dev\ip\Azure-ResourceModules\ResourceModules\modules\db-for-postgre-sql\flexible-server.test\public\main.test.bicep(19,7) : Warning no-unused-params: Parameter "password" is declared but never used. [https://aka.ms/bicep/linter/no-unused-params]
  • ERROR: C:\dev\ip\Azure-ResourceModules\ResourceModules\modules\resources\tags.test\rg\main.test.bicep(9,41) : Error BCP057: The name "namePrefix" does not exist in the current context.

@eriqua
Copy link
Contributor Author

eriqua commented Oct 22, 2023

Closing in favor of #4130

@eriqua eriqua closed this Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] modules category: modules [cat] testing category: testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants