Skip to content

[Modules] Fix API version issues#3585

Closed
MariusStorhaug wants to merge 23 commits intoAzure:mainfrom
MariusStorhaug:patch/privateEndpoints
Closed

[Modules] Fix API version issues#3585
MariusStorhaug wants to merge 23 commits intoAzure:mainfrom
MariusStorhaug:patch/privateEndpoints

Conversation

@MariusStorhaug
Copy link
Contributor

@MariusStorhaug MariusStorhaug commented Aug 17, 2023

Description

All pipelines be breaking on my end, so thought I would just bump a version and regen all files.

  • API version bump of modules:
    • applicationGateways (2022-07-01) -> (2023-05-01)
    • applicationSecurityGroups (2022-07-01) -> (2023-05-01)
    • azureFirewalls (2022-07-01) -> (2023-05-01)
    • connections (2022-07-01) -> (2023-05-01)
    • ddosProtectionPlans (2022-07-01) -> (2023-05-01)
    • expressRouteCircuits (2022-07-01) -> (2023-05-01)
    • firewallPolicies (2022-07-01) -> (2023-05-01)
    • ipGroups (2022-07-01) -> (2023-05-01)
    • loadBalancers (2022-07-01) -> (2023-05-01)
    • localNetworkGateways (2022-07-01) -> (2023-05-01)
    • natGateways (2022-07-01) -> (2023-05-01)
    • networkInterfaces (2022-07-01) -> (2023-05-01)
    • networkSecurityGroups (2022-07-01) -> (2023-05-01)
    • networkWatchers (2022-07-01) -> (2023-05-01)
    • networkWatchers/connectionMonitors (2022-07-01) -> (2023-05-01)
    • networkWatchers/connectionMonitors (2022-07-01) -> (2023-05-01)
    • networkWatchers/flowLogs (2022-07-01) -> (2023-05-01)
    • networkWatchers/flowLogs (2022-07-01) -> (2023-05-01)
    • privateEndpoints (2022-07-01) -> (2023-05-01)
    • privateEndpoints/privateDnsZoneGroups (2022-07-01) -> (2023-04-01)
    • publicIPAddresses (2022-07-01) -> (2023-05-01)
    • publicIPPrefixes (2022-07-01) -> (2023-05-01)
    • routeTables (2022-07-01) -> (2023-05-01)
    • serviceEndpointPolicies (2022-07-01) -> (2023-05-01)
    • virtualNetworkGateways (2022-07-01) -> (2023-05-01)
    • virtualNetworks (2022-07-01) -> (2023-05-01)
    • virtualWans (2022-07-01) -> (2023-05-01)
    • vpnGateways (2022-07-01) -> (2023-05-01)
    • vpnSites (2022-07-01) -> (2023-05-01)
  • Regen readme and ARM templates for all modules.

Pipeline references

Pipeline
Storage - StorageAccounts
AppConfiguration - ConfigurationStores
Network - NetworkInterfaces

Type of Change

Please delete options that are not relevant.

  • Patch (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@MariusStorhaug MariusStorhaug requested a review from a team as a code owner August 17, 2023 14:18
@MariusStorhaug MariusStorhaug changed the title Patch/private endpoints [Modules] Patch privateEndpoints API version Aug 17, 2023
@MariusStorhaug MariusStorhaug marked this pull request as draft August 17, 2023 14:46
@MariusStorhaug MariusStorhaug marked this pull request as ready for review August 17, 2023 15:58
@MariusStorhaug
Copy link
Contributor Author

I have a very limited environment on my own side, so let me know which pipelines you might want me to run. If possible, might be worth pulling it in to a branch in Azure/ResourceModules and run a test from there if possible.

Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MariusStorhaug, as we're currently working on a dev branch to rename all module folders to a singular form and comply with the public Bicep registry naming, I'm putting on hold this PR until #3571 and #3573 are merged

@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] modules category: modules labels Aug 20, 2023
@MariusStorhaug
Copy link
Contributor Author

@AlexanderSehr @eriqua : I see more breakages in pipeline due to APIs growing old. Want me to include them in this PR or a separate one? A significant one is the networking RP.

@MariusStorhaug
Copy link
Contributor Author

MariusStorhaug commented Aug 20, 2023

Merge conflict resolved by regening the host-pools main.json file.

@MariusStorhaug MariusStorhaug changed the title [Modules] Patch privateEndpoints API version [Modules] Fix API version issues Aug 20, 2023
@MariusStorhaug MariusStorhaug marked this pull request as draft August 20, 2023 14:35
@AlexanderSehr
Copy link
Contributor

@AlexanderSehr @eriqua : I see more breakages in pipeline due to APIs growing old. Want me to include them in this PR or a separate one? A significant one is the networking RP.

Though it pains me to say, I'd suggest to wait to limit conflicts with the upcoming breaking changes.

@MariusStorhaug
Copy link
Contributor Author

@AlexanderSehr @eriqua : I see more breakages in pipeline due to APIs growing old. Want me to include them in this PR or a separate one? A significant one is the networking RP.

Though it pains me to say, I'd suggest to wait to limit conflicts with the upcoming breaking changes.

Any ETA for that change? :)

@AlexanderSehr
Copy link
Contributor

@AlexanderSehr @eriqua : I see more breakages in pipeline due to APIs growing old. Want me to include them in this PR or a separate one? A significant one is the networking RP.

Though it pains me to say, I'd suggest to wait to limit conflicts with the upcoming breaking changes.

Any ETA for that change? :)

Weeks ago 😬 but we're though most of it. So I'd expect within the next week or two

@eriqua
Copy link
Contributor

eriqua commented Aug 20, 2023

@AlexanderSehr @eriqua : I see more breakages in pipeline due to APIs growing old. Want me to include them in this PR or a separate one? A significant one is the networking RP.

Though it pains me to say, I'd suggest to wait to limit conflicts with the upcoming breaking changes.

Any ETA for that change? :)

@AlexanderSehr @eriqua : I see more breakages in pipeline due to APIs growing old. Want me to include them in this PR or a separate one? A significant one is the networking RP.

Though it pains me to say, I'd suggest to wait to limit conflicts with the upcoming breaking changes.

Any ETA for that change? :)

Weeks ago 😬 but we're though most of it. So I'd expect within the next week or two

As soon as PR #3573 gets merged 👯

@AlexanderSehr
Copy link
Contributor

@AlexanderSehr @eriqua : I see more breakages in pipeline due to APIs growing old. Want me to include them in this PR or a separate one? A significant one is the networking RP.

Though it pains me to say, I'd suggest to wait to limit conflicts with the upcoming breaking changes.

Any ETA for that change? :)

@AlexanderSehr @eriqua : I see more breakages in pipeline due to APIs growing old. Want me to include them in this PR or a separate one? A significant one is the networking RP.

Though it pains me to say, I'd suggest to wait to limit conflicts with the upcoming breaking changes.

Any ETA for that change? :)

Weeks ago 😬 but we're though most of it. So I'd expect within the next week or two

As soon as PR #3573 gets merged 👯

PR is merged. Now we have to fix a bunch of Api versions 😄

@MariusStorhaug
Copy link
Contributor Author

Too many conflicts to care. Reboot PR: #3665

@MariusStorhaug MariusStorhaug deleted the patch/privateEndpoints branch August 22, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] modules category: modules enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants