Skip to content

[MAJOR/BREAKING] Adding OIDC login functionality#1452

Merged
MariusStorhaug merged 12 commits intoAzure:issue/1450from
MariusStorhaug:users/mast/1450
Jun 26, 2022
Merged

[MAJOR/BREAKING] Adding OIDC login functionality#1452
MariusStorhaug merged 12 commits intoAzure:issue/1450from
MariusStorhaug:users/mast/1450

Conversation

@MariusStorhaug
Copy link
Contributor

@MariusStorhaug MariusStorhaug commented May 30, 2022

Description

Closing #1450

POCing the OpenID Connect passwordless logon mechanism for Azure AD.

Pipeline references

Pipeline
Batch: BatchAccounts

https://github.com/MariusStorhaug/ResourceModules/runs/6661434629?check_suite_focus=true#step:4:235

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@MariusStorhaug MariusStorhaug self-assigned this May 30, 2022
@MariusStorhaug MariusStorhaug added [cat] pipelines category: pipelines [cat] github category: GitHub labels May 30, 2022
@jontreynes
Copy link
Contributor

Curious, is the ARM_CLIENT_ID just a string of the app registration id guid?

@MariusStorhaug
Copy link
Contributor Author

@mblant Any input from you regarding swapping out the current SPN + Secret with OIDC federation for GH Action logon? It another breaking change but think we should lead by example and push customers to a more secure setup. Thoughts?

@MariusStorhaug
Copy link
Contributor Author

@jontreynes ARM_CLIENT_ID is indeed the GUID appID of the app registration yes.

@MariusStorhaug MariusStorhaug changed the title [POC] Adding OIDC login functionality [MAJOR/BREAKING] Adding OIDC login functionality Jun 9, 2022
@MariusStorhaug MariusStorhaug changed the base branch from main to issue/1450 June 26, 2022 11:25
@MariusStorhaug MariusStorhaug marked this pull request as ready for review June 26, 2022 12:09
@MariusStorhaug MariusStorhaug merged commit dff8869 into Azure:issue/1450 Jun 26, 2022
@MariusStorhaug MariusStorhaug deleted the users/mast/1450 branch June 26, 2022 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] github category: GitHub [cat] pipelines category: pipelines

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Feature Request] BREAKING change: Authenticate to Azure from GH with OpenID Connect

2 participants