[MAJOR/BREAKING] Adding OIDC login functionality#1452
Merged
MariusStorhaug merged 12 commits intoAzure:issue/1450from Jun 26, 2022
MariusStorhaug:users/mast/1450
Merged
[MAJOR/BREAKING] Adding OIDC login functionality#1452MariusStorhaug merged 12 commits intoAzure:issue/1450from MariusStorhaug:users/mast/1450
MariusStorhaug merged 12 commits intoAzure:issue/1450from
MariusStorhaug:users/mast/1450
Conversation
1 task
Contributor
|
Curious, is the ARM_CLIENT_ID just a string of the app registration id guid? |
Contributor
Author
|
@mblant Any input from you regarding swapping out the current SPN + Secret with OIDC federation for GH Action logon? It another breaking change but think we should lead by example and push customers to a more secure setup. Thoughts? |
Contributor
Author
|
@jontreynes ARM_CLIENT_ID is indeed the GUID appID of the app registration yes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closing #1450
POCing the OpenID Connect passwordless logon mechanism for Azure AD.
Pipeline references
https://github.com/MariusStorhaug/ResourceModules/runs/6661434629?check_suite_focus=true#step:4:235
Type of Change
Please delete options that are not relevant.
Checklist