Add docstrings#1377
Add docstrings#1377Nikoleta-v3 merged 10 commits intoAxelrod-Python:devfrom caddycarine:add_docstrings
Conversation
Added docstrings to files which had not merged.
Simplified chained comparisons in SelfSteem
Changed set(["game"]) to {"game"} to reduce function call
Deleted duplicate TestIdentityDualTransformer class
.isort.cfg
Outdated
| force_grid_wrap = 0 | ||
| combine_as_imports = True | ||
| line_length = 80 | ||
| line_length = 88 |
There was a problem hiding this comment.
This line here is causing a number of other things to break.
There was a problem hiding this comment.
python -m isort --recursive axelrod/. and python -m black -l 80 .
seem to do conflicting changes.
There was a problem hiding this comment.
They shouldn't based on the setting in https://github.com/Axelrod-Python/Axelrod/blob/dev/.isort.cfg but it could be that the specific version of isort you're using isn't the one we have setup in the CI: https://github.com/Axelrod-Python/Axelrod/blob/dev/.github/workflows/config.yml#L52
(We should clarify that somewhere.)
There was a problem hiding this comment.
Sorry this PR is proving to be a pain for you, if there's something specific I can do to assist please ask. We'll have to have a think afterwards how we can avoid the friction you're experiencing. It hasn't really happened in the past but we've made a number of small tweaks to our CI recently which might be the cause.
There was a problem hiding this comment.
I can't get both of them to agree on these four files:
- axelrod\strategies\titfortat.py
- axelrod\tests\property.py
- axelrod\tests\strategies\test_evolvable_player.py
- axelrod\tests\strategies\test_finite_state_machines.py
Would appreciate any suggestions/recommendations.
There was a problem hiding this comment.
I've opened https://github.com/caddycarine/Axelrod/pull/1 on your fork. This is a PR to this branch so once you merge that it should update this PR and should get the CI to pass.
The main problem seemed to be caddycarine@bbe9a72
There was a problem hiding this comment.
Your solution works 😁!
Thanks.
Modified .isort.cfg to resolve merge issues.
1. Modified max.size in strategy_lists because len(axl.short_run_time_strategies) < len(axl.strategies) in property.py 2. Added classifiers_list method, in test_filtering.py, and used it in test_boolean_filtering.
Fix isort config
| } | ||
|
|
||
|
|
||
| class TestIdentityDualTransformer(TestPlayer): |
There was a problem hiding this comment.
Repetition; an identical class was defined earlier..
drvinceknight
left a comment
drvinceknight
left a comment
There was a problem hiding this comment.
This looks good to me. 👍
4 participants
Add docstrings to strategy methods so they don't display the default placeholder docstring and simplify chained comparisons in SelfSteem class