Add a property based test for valid strategies#1374
Conversation
Not sure if this is overkill @marcharper, just thought it could be worth having.
|
Want to move it to (BTW this is the kind of thing that type hinting should catch...) |
I thought about that but thought that it would perhaps add a lot to the run time and given that we always have explicit test for the other players perhaps it wasn't needed? Could limit the turns I suppose...
After a long journey (that is still interrupted with swearing at mypy) I am 100% on board with type hints :) |
|
It's fine as is if you prefer |
I suggest we leave as is but perhaps we open an issue to either specifically target type hinting the strategies strategy method or add a test like this? |
Not sure if this is overkill @marcharper, just thought it could be worth
having.
This is a PR to #1373