Add SQLite tables command supporting list and csv format#5
Merged
Conversation
Contributor
|
Works well @sejas! We will need to update docs and add tests before we merge, though. |
1 task
wojtekn
approved these changes
Nov 26, 2024
Contributor
wojtekn
left a comment
There was a problem hiding this comment.
Looks good, works as expected. Thanks for updating readme.
| $tables = $stmt->fetchAll( PDO::FETCH_COLUMN ); | ||
|
|
||
| // Remove system tables | ||
| $tables_to_exclude = array( '_mysql_data_types_cache' ); |
Contributor
There was a problem hiding this comment.
As we are ignoring some tables as a part of the SQL query, would it make sense to do the same for this one?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
listandcsvExamples
Testing instructions
composer install --no-devin this repocdinto the root directory of a Studio sitewp sqlite tables --format=csv --require=/path/to/wp-cli-sqlite-command/command.phpwp sqlite tables --require=/path/to/wp-cli-sqlite-command/command.php