Set default SQL modes and other options for database import#17
Merged
Conversation
JanJakes
force-pushed
the
fix-sql-modes
branch
from
4039840 to
2e415ce
Compare
ivan-ottinger
approved these changes
Oct 31, 2025
ivan-ottinger
left a comment
ivan-ottinger
left a comment
There was a problem hiding this comment.
Thank you for the fix, @JanJakes! The changes look good and I can confirm they fix the import issue. 👌🏼
I have tested the changes directly in Studio by importing problematic export. I have also run several more import using different export files. All went well.
@wojtekn thanks for including clear instructions in older Studio PR: Automattic/studio#1506. They were helpful in testing this one as well. 🙂
|
Thanks for merging and releasing the new version, Wojtek. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some backups don't include
SET SQL_MODE = …statements, but they do rely on WordPress-compatible SQL modes to be set during import (which are different from MySQL defaults).This works with
wp db import, because the command handles that for backups imported from files.The new SQLite driver supports some SQL modes, but the
wp sqlite importcommand doesn't set any defaults. This may cause some backups to fail to import into the SQLite database.To fix this, we need to set permissive defaults for the
wp sqlite importcommand, just like the nativemysqldumpcommand does.Fixes WordPress/sqlite-database-integration#253.