Fix sqlite export by escaping strings with numbers and e character

[sejas]

Related to pfHvTO-C8-p2#comment-596

Change is_numeric comparison in favor of ctype_digit to avoid confusion with alphanumeric strings with e character like 123e99. This will prevent the issue when exporting mailpoet table.

is_numeric( '123e99' ) -> True
ctype_digit( '123e99' ) -> False

Testing Instructions

Test with Studio:

• Checkout Studio repo https://github.com/Automattic/studio
• Apply this diff

diff --git a/src/setup-wp-server-files.ts b/src/setup-wp-server-files.ts
index 611d4fd0..751f8e91 100644
--- a/src/setup-wp-server-files.ts
+++ b/src/setup-wp-server-files.ts
@@ -91,7 +91,7 @@ async function copyBundledWPCLI() {
 
 async function copyBundledSQLiteCommand() {
 	const bundledSqliteCommandPath = path.join( getResourcesPath(), 'wp-files', 'sqlite-command' );
-	const bundledSqliteCommandVersion = await getSQLiteCommandVersion( bundledSqliteCommandPath );
+	const bundledSqliteCommandVersion = 'v1.1.2';
 	if ( ! bundledSqliteCommandVersion ) {
 		return;
 	}
@@ -120,6 +120,4 @@ export async function updateWPServerFiles() {
 	await updateLatestSqliteVersion();
 	const provider = new WpNowProvider();
 	await provider.updateLatestWPCliVersion();
-
-	await updateLatestSQLiteCommandVersion();
 }

• Run npm install
• Delete the folder studio/wp-files/sqlite-command
• Delete also the folder ~/Library/Application\ Support/Studio/server-files/sqlite-command
• Checkout this repository and this branch
• Run composer install --no-dev --optimize-autoloader --ignore-platform-reqs
• Create a symbolic link from wp-cli-sqlite-command to studio/wp-files/sqlite-command.
• Run npm start in studio folder
• Create a site
• Go to import tab
• Drop this sql file

wp_mailpoet_newsletter_links.sql

• Click on export database
• Observe the produced SQL dump has the escaped value '123e99'.

Before

After

[epeicher]

Thanks Antonio for fixing this so promptly! I have tested it, and I can confirm that I see the value quoted as expected when applying this patch, while I see the previous unquoted value in the production version. LGTM!

Production	This branch

[JanJakes]

Looks good, thanks for working on this!