Merged
Conversation
Member
|
Nah let's just switch to wxwidgets |
Member
Author
|
as you can see on this history, Qt6 CI is very difficult to do, so it's not included |
Member
Author
|
most of this
|
Member
|
can you add 6.0 to the build matrix to verify the branch works? I think CI is essential - otherwise qt6 support is only theoretical. |
Member
Author
|
No i can't, the tooling isn't able to install the needed Qt6 websockets addon |
Member
Author
|
The CI will have to be done at a later time when the tooling has caught up to Qt6 |
Salanto
approved these changes
Dec 21, 2022
Contributor
Salanto
left a comment
Salanto
left a comment
There was a problem hiding this comment.
LGTM, about Qt6 support, it will be a question of when Linux pulls up the version, but in theory it suffices when the obvious ones are taken care of, imo.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
turns out it didn't take much
depends on #818