Objections no longer force you into preanimations#697
Merged
Crystalwarrior merged 5 commits intomasterfrom Mar 25, 2022
Merged
Conversation
Fix preanim zoom not toggling the checkbox from char.ini, but deprecated "4" doing it
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Member
|
Huh, what? I know I fixed this already. When did this sneak back in? |
Contributor
Author
Honestly no clue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finally, you can use the Objection shout without being forced into preanim, allowing you to have control what sprite you'll use once objection is over - idle or pre.
This is backwards compatible with every client prior as well due to how arbitrary this "force pre when objecting" thing was lol
Fixes #692
Also fixes preanim zoom emote mod (6) not getting its pre checkbox getting ticked on, forcing char.ini makers to use the deprecated emote mod (4)