Expand .css power by giving object names to all AO UI elements#534
Merged
Expand .css power by giving object names to all AO UI elements#534
Conversation
fix ic chatlog placeholder text not being translated
in1tiate
reviewed
Apr 23, 2021
| } | ||
| for (int c = 0; c < max_colors; ++c) { | ||
| QColor color = ao_app->get_chat_color("c" + QString::number(c), "default"); | ||
| QColor color = ao_app->get_chat_color("c" + QString::number(c), ""); |
Contributor
Author
There was a problem hiding this comment.
This way, it doesn't head to base/misc/default/chat_config.ini or base/themes/current_theme/misc/default/chat_config.ini, prioritizing the current theme's chat_config.ini and only falling back to the base/misc/default/config.ini monstrosity as a last resort
…ibility misc/default/config.ini vs themes/current_theme/misc/default/config.ini
…eyOnline/AO2-Client into crystalwarrior/css-expand
oldmud0
approved these changes
Apr 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows theme designers to actually refer to specific AO elements rather than having to do hacky BS
see https://doc.qt.io/qt-5/stylesheet-syntax.html