[2.8.6] Demo Recording/Playback by Crystalwarrior · Pull Request #337 · AttorneyOnline/AO2-Client

Crystalwarrior · 2020-11-11T19:06:28Z

This implements support for a demo system by recording networking packets for anything that is relevant to this system.
Evidence might be recorded in the future, but it can potentially overload the filesize of .demo files due to how fucking cursed evidence packets are.

TODO:

an option to enable/disable demo recordings in the settings

Demo playback system with:

Playing the demo file as it would play out in-client
Playing the demo file skipping dead air that goes over a certain ms threshold (like 10000 for wait time more than 10s to be skipped)
Skipping forward
Playback from lobby as an option instead of doing it when present on a server

Features that would be nice but are kind of extra:

Reading the demo file frame-by-frame
Rewinding
Timeline you can navigate with notches etc.

implements #317
Remake of #329 to allow contributions from the whole team

Set up elapsedtimer to generate wait# stuff between packets recorded TODO: playback

mposs00 · 2020-11-13T08:36:22Z

last commit makes it do the thing it needs to work. there are just some details that need implementation:

you start playback with a command which is fine for now i guess
need a way to actually specify a filename
IC messages don't show up because char list is hell. This may take some work to get figured out.

Pop up file dialog box *before* establishing the connection, not after. TODO: * Fix having to load the same file *twice* to be able to connect to the demo server for some reason * Fix the segfault caused by calling the playback() function when there's no remaining data, it's almost like demo_data.isEmpty() is ignored for whatever reason???

…ser fails to obtain a good demo file

…ng this function

…happens in the Demo playback local server

Use file_exists() to be more consistent in append_to_file

…e such as SC, SM, CI etc. (TODO: parity???) Remove useless debug stuff

…wait in milliseconds between wait packets Add /pause or | shorthand to pause playback Re-add /play and keep > as a shorthand Remove clientside restrictions from sending empty OOC messages and sending OOC messages without a name - these should be serverside.

Default the character to Spectator char no matter the selection in CSS

…l Character Select Screen list to still be parsed corectly, using the character folder in the MS packet as reference. Allow servers with no selectable characters to still be properly loaded Bypass the Character Select Screen when joining a server with no character select screen and automatically become a spectator

…xist Add a /load command letting you load a demo file without rejoining the demo server (the CS packet will not be properly handled but I cannot think of a single tangible problem this causes lol) Make sure all DEMO CT messages are colored properly

…ed a demo server after leaving another

…disable auto logging when running the game

oldmud0 · 2020-11-16T04:40:14Z

src/courtroom.cpp

  chatlogpiece log_entry(p_name, p_showname, p_message, p_action, p_color);
  ic_chatlog_history.append(log_entry);
-  if (ao_app->get_auto_logging_enabled())
+  if (ao_app->get_auto_logging_enabled() && !ao_app->log_filename.contains("/Demo playback/"))


I didn't realize this copypasting BS existed with get_auto_logging_enabled. Let's try not to make it worse.

… prioritized with MS (IC chat) packets being used as the anchor.

# Conflicts: # src/courtroom.cpp # src/packet_distribution.cpp

src/demoserver.cpp

src/packet_distribution.cpp

…mo file, resulting in characters having something like "#1" in their message breaking that specific message

Crystalwarrior · 2021-01-12T08:30:35Z

@oldmud0 @scatterflower

# Conflicts: # src/courtroom.cpp # src/packet_distribution.cpp

… bugged the code Fix aopacket being busted up as well

Crystalwarrior · 2021-01-12T09:47:31Z

I don't have the energy to continue polishing this branch, everything I need to work works and there have not been any crashes or bad stuff happening with it even if the charlist packet is missing. If you want to polish it you can do so on this branch, though I'd prefer we merged this in as-is and created separate polish branches after the fact once we get 2.9 released and we have minor versions for inevitable bugfixing down the line

src/text_file_functions.cpp

i took care of the issues

src/demoserver.cpp

stonedDiscord

good work

Co-authored-by: oldmud0 <oldmud0@users.noreply.github.com>

…line/AO2-Client into feature/demo-playback

stonedDiscord

yes i wrote this code

initial commit with horrible code dupcliation haha lol

36a09bd

Set up elapsedtimer to generate wait# stuff between packets recorded TODO: playback

Crystalwarrior assigned mposs00 Nov 11, 2020

Crystalwarrior mentioned this pull request Nov 11, 2020

Demo Recording/Playback System #329

Closed

8 tasks

scatterflower added 2 commits November 11, 2020 14:23

implement groundwork for internal demo server

a11d03c

add core playback functionality

798e84e

scatterflower and others added 16 commits November 13, 2020 02:51

make it work kinda by including SC packet in demo

88a1199

Add a file dialog for loading a demo file instead of a hardcoded path

c4b4c1a

Clear demo data when loading a demo file to prevent stacking demos

eb8e982

Properly disconnect the client when sending the request for file brow…

f3003cc

…ser fails to obtain a good demo file

Fix append_to_file newlining even if file didn't exist prior to calli…

917e0ec

…ng this function

Add a very scuffed exception to not log or demo record anything that …

0069dcd

…happens in the Demo playback local server

Reduce invalid file spam by checking for non-logging server better

b527118

Use file_exists() to be more consistent in append_to_file

Fix the client crashing when receiving loading packets etc. at runtim…

a2eaccc

…e such as SC, SM, CI etc. (TODO: parity???) Remove useless debug stuff

Preserve newlines for demo packets such as "CT", "MS" etc.

2bc9991

Empty music list

5f71d33

Default the character to Spectator char no matter the selection in CSS

Fix logs bleeding into each other if you disabled logging or you join…

ec7775b

…ed a demo server after leaving another

Prevent logging even if log_filename is defined because a user might …

3bc4abe

…disable auto logging when running the game

oldmud0 reviewed Nov 16, 2020

View reviewed changes

Crystalwarrior added 3 commits November 16, 2020 16:47

Fix custom shownames not appearing in the IC logs

54e2a96

Set up new logic for max_wait, meaning that dead air being skipped is…

0241c44

… prioritized with MS (IC chat) packets being used as the anchor.

Better logic for min_wait to only affect important packets (IC Chat)

aee47d4

oldmud0 added this to the 2.9 milestone Dec 28, 2020

Merge branch 'master' into feature/demo-playback

662a9e2

# Conflicts: # src/courtroom.cpp # src/packet_distribution.cpp

mposs00 previously requested changes Jan 8, 2021

View reviewed changes

src/demoserver.cpp Outdated Show resolved Hide resolved

src/demoserver.cpp Show resolved Hide resolved

src/packet_distribution.cpp Outdated Show resolved Hide resolved

Fix encoding not being performed on packets that are saved to the .de…

16454df

…mo file, resulting in characters having something like "#1" in their message breaking that specific message

Crystalwarrior added 2 commits January 12, 2021 11:35

Merge branch 'master' into feature/demo-playback

64f3d23

# Conflicts: # src/courtroom.cpp # src/packet_distribution.cpp

Fix a weird setup in courtroom.cpp that happened out of the merge and…

1754674

… bugged the code Fix aopacket being busted up as well

Crystalwarrior requested review from mposs00 and oldmud0 January 12, 2021 09:48

add missing feature flags to the demoserver

55d2f6a

Crystalwarrior commented Jan 12, 2021

View reviewed changes

src/text_file_functions.cpp Show resolved Hide resolved

stonedDiscord added 2 commits January 13, 2021 16:53

use random port

a2dbd0e

move writing to the demo file to a function

365e018

oldmud0 reviewed Jan 13, 2021

View reviewed changes

src/demoserver.cpp Outdated Show resolved Hide resolved

oldmud0 reviewed Jan 13, 2021

View reviewed changes

src/demoserver.cpp Outdated Show resolved Hide resolved

src/demoserver.cpp Show resolved Hide resolved

stonedDiscord previously approved these changes Jan 13, 2021

View reviewed changes

only listen on localhost

ef19441

Co-authored-by: oldmud0 <oldmud0@users.noreply.github.com>

stonedDiscord dismissed their stale review via ef19441 January 13, 2021 17:00

stonedDiscord added 5 commits January 13, 2021 18:01

remove copypasta

eefbf87

Merge branch 'feature/demo-playback' of https://github.com/AttorneyOn…

d534ae3

…line/AO2-Client into feature/demo-playback

add a help to the demo server

4082b62

fix empty demo disconnecting the server

9c7ace7

tell the user how to begin

e42ba82

Crystalwarrior requested review from Iamgoofball and in1tiate January 13, 2021 21:23

stonedDiscord self-requested a review January 13, 2021 21:24

stonedDiscord approved these changes Jan 13, 2021

View reviewed changes

stonedDiscord merged commit 2f84055 into master Jan 13, 2021

oldmud0 deleted the feature/demo-playback branch February 14, 2021 04:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[2.8.6] Demo Recording/Playback#337

[2.8.6] Demo Recording/Playback#337
stonedDiscord merged 35 commits intomasterfrom
feature/demo-playback

Crystalwarrior commented Nov 11, 2020 •

edited

Loading

Uh oh!

mposs00 commented Nov 13, 2020

Uh oh!

oldmud0 Nov 16, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Crystalwarrior commented Jan 12, 2021

Uh oh!

Crystalwarrior commented Jan 12, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stonedDiscord left a comment

Uh oh!

stonedDiscord left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Crystalwarrior commented Nov 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mposs00 commented Nov 13, 2020

Uh oh!

oldmud0 Nov 16, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Crystalwarrior commented Jan 12, 2021

Uh oh!

Crystalwarrior commented Jan 12, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stonedDiscord left a comment

Choose a reason for hiding this comment

Uh oh!

stonedDiscord left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Crystalwarrior commented Nov 11, 2020 •

edited

Loading