restore appimage_get_elf_size#174
Closed
lalten wants to merge 1 commit intoAppImageCommunity:masterfrom
Closed
Conversation
TheAssassin
reviewed
Aug 18, 2022
| return sht_end > last_section_end ? sht_end : last_section_end; | ||
| } | ||
|
|
||
| ssize_t appimage_get_elf_size(const char* fname) { |
Member
There was a problem hiding this comment.
Hm, not really a fan of reimplementing this although we have appimage_get_payload_offset... need to think about this.
Author
|
Likely this can be closed with the same reason as #160 (comment)? |
Member
|
Ah, yes, indeed. Thanks for the heads-up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#160 but rebased onto latest master (as of 2022-08-18), aa7d9fb