Merge pull request #72730 from ClickHouse/fix-keeper-internal-ssl#578
Closed
ianton-ru wants to merge 1 commit intoAltinity:customizations/24.8.8from
Closed
Merge pull request #72730 from ClickHouse/fix-keeper-internal-ssl#578ianton-ru wants to merge 1 commit intoAltinity:customizations/24.8.8from
ianton-ru wants to merge 1 commit intoAltinity:customizations/24.8.8from
Conversation
…al-ssl Fix advanced SSL configuration for Keeper's internal communication
Author
|
Closed as duplicate of #579 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of github.com/ClickHouse/pull/72730
Fix advanced SSL configuration for Keeper's internal communication
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix advanced SSL configuration for Keeper's internal communication
Fix ClickHouse#72542
SSL was accidentally disabled always in ClickHouse#69582
So it wasn't properly tested.
Now I added a check in the test to verify first SSL is used before testing different configurations.