Skip to content

25.3.8 Stable: Add guard for local data lakes#1533

Merged
zvonand merged 5 commits intoreleases/25.3.8from
fix/25.3.8/add-local-data-lake-guard
Mar 19, 2026
Merged

25.3.8 Stable: Add guard for local data lakes#1533
zvonand merged 5 commits intoreleases/25.3.8from
fix/25.3.8/add-local-data-lake-guard

Conversation

@zvonand
Copy link
Collaborator

@zvonand zvonand commented Mar 16, 2026

Changelog category (leave one):

  • Critical Bug Fix (crash, data loss, RBAC) or LOGICAL_ERROR

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Add setting allow_local_data_lakes. Off by default.

CI/CD Options

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All with Aarch64
  • All Regression
  • Disable CI Cache

Regression jobs to run:

  • Fast suites (mostly <1h)
  • Aggregate Functions (2h)
  • Alter (1.5h)
  • Benchmark (30m)
  • ClickHouse Keeper (1h)
  • Iceberg (2h)
  • LDAP (1h)
  • Parquet (1.5h)
  • RBAC (1.5h)
  • SSL Server (1h)
  • S3 (2h)
  • Tiered Storage (2h)

@zvonand zvonand added 25.3 25.3.8 25.3.8 Altinity Stable labels Mar 16, 2026
@zvonand zvonand merged commit 313ddbc into releases/25.3.8 Mar 19, 2026
645 of 710 checks passed
@alsugiliazova
Copy link
Member

Manual tests are passing, waiting for CI to finish.

@alsugiliazova
Copy link
Member

alsugiliazova commented Mar 20, 2026

Audit Report: PR #1533 — Add guard for local data lakes

Confirmed defects

No confirmed defects in reviewed scope.


Detailed analysis (reference)

Invariants

  1. Local data lake access (IcebergLocal engine, icebergLocal table function) requires allow_local_data_lakes == true.
  2. When disabled, all entrypoints throw before any storage/object-storage creation.

Logical branch coverage

  • Storage engine, setting off: Exception thrown before createStorageObjectStorage.
  • Storage engine, setting on: Proceeds to create storage.
  • Table function, setting off: Exception at first invoked method (parseArguments, getActualTableStructure, or executeImpl).
  • Table function, setting on: All three methods proceed.

Not confirmed (low priority)

  • Setting description: "DeltaLakeLocal" mentioned but no such engine exists; "etc." covers future additions. Documentation preference, not a defect.

@alsugiliazova
Copy link
Member

PR #1533 CI Verification Report

CI Results on Merge Commit: 189 success, 8 failures, 1 cancelled, 2 skipped

Failures (8) — none related to PR

# Suite Error Related to PR
1 RegressionTestsRelease / Common (iceberg) REST catalog connection refused (localhost:5000) — 392 test errors, all from service not starting No — infrastructure
2 RegressionTestsAarch64 / Common (iceberg) Same REST catalog connection refused pattern No — infrastructure
3 RegressionTestsRelease / Common (aggregate_functions) Only XFail results (expected failures for mannWhitneyUTestMerge, linked to ClickHouse#69192); job marked failure due to /upload step No — known issue + upload infra
4 RegressionTestsAarch64 / Common (rbac) Only XFail results (timezone tests, SSH key tests linked to ClickHouse#70898); job marked failure due to /upload step failures No — known issues + upload infra
5 RegressionTestsAarch64 / Alter (attach) Tests passed but /upload step failed repeatedly No — upload infrastructure
6 IntegrationTestsTsan / Integration tests (tsan)-1 Status comment update failed No — infrastructure
7 IntegrationTestsTsan / Integration tests (tsan)-7 Status comment update failed No — infrastructure
8 GrypeScan (server, -alpine) / Grype Scan CVE scan No — infrastructure

Cancelled (1)

Suite Reason
RegressionTestsAarch64 / Common (aggregate_functions) Cancelled

Passed Suites (189) — comprehensive coverage

Builds & Packaging:

  • Builds report, Sign release, Sign aarch64, Docker server/keeper images, Install packages (release, aarch64), Compatibility checks — all passed

Stateless Tests:

  • FunctionalStatelessTestRelease, FunctionalStatelessTestAarch64 — both passed

Integration Tests (release):

  • IntegrationTestsRelease shards 0-7 — all 8 passed

Skipped (2)

TSAN, MSAN, UBSAN, Coverage excluded by PR author. Fast test skipped.

Conclusion

PR #1533 is correctly merged.

@alsugiliazova alsugiliazova added the verified Verified by QA label Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

25.3 25.3.8 25.3.8 Altinity Stable 25.3.8.10042 verified Verified by QA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants