Skip to content

25.8.15 Backport of #89367: Crash in IN function where columns have different types and many columns are involved#1339

Merged
zvonand merged 2 commits intoreleases/25.8.15from
backports/25.8.15/89367
Jan 28, 2026
Merged

25.8.15 Backport of #89367: Crash in IN function where columns have different types and many columns are involved#1339
zvonand merged 2 commits intoreleases/25.8.15from
backports/25.8.15/89367

Conversation

@zvonand
Copy link
Collaborator

@zvonand zvonand commented Jan 27, 2026

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Possible crash/undefined behavior in IN function where primary key column types are different from IN function right side column types (ClickHouse#89367 by @ilejn)

CI/CD Options

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All with Aarch64
  • All Regression
  • Disable CI Cache

Regression jobs to run:

  • Fast suites (mostly <1h)
  • Aggregate Functions (2h)
  • Alter (1.5h)
  • Benchmark (30m)
  • ClickHouse Keeper (1h)
  • Iceberg (2h)
  • LDAP (1h)
  • Parquet (1.5h)
  • RBAC (1.5h)
  • SSL Server (1h)
  • S3 (2h)
  • Tiered Storage (2h)

25.8.13 Backport of ClickHouse#89367: Crash in IN function where columns have different types and many columns are involved
@github-actions
Copy link

github-actions bot commented Jan 27, 2026

Workflow [PR], commit [a80599f]

@zvonand
Copy link
Collaborator Author

zvonand commented Jan 28, 2026

S3 fails: Altinity/clickhouse-regression#93

Aggregate fails: uniqTheta was updated in upstream, not related, test will be updated separately by QA team

@zvonand zvonand merged commit 65384b3 into releases/25.8.15 Jan 28, 2026
379 of 395 checks passed
@DimensionWieldr
Copy link
Collaborator

DimensionWieldr commented Feb 3, 2026

CI Failure Analysis

1. Regression Tests (aggregate_functions_1, S3 suites) - Pre-existing Failures

Failures: uniqTheta, zero copy replication

Evidence these are pre-existing on base branch (releases/25.8.15) MasterCI #21579463803:

  • AggregateFunctions (1) = failure (x86_64 + aarch64)
  • S3 (aws_s3, 2) = failure (x86_64 + aarch64)
  • S3 (azure, 2) = failure (x86_64 + aarch64)
  • S3 (minio, 2) = failure (x86_64 + aarch64)

Verdict: Pre-existing failures on base branch. Unrelated to PR changes.


2. Alter Tests (alter_attach_1, alter_replace) - Infrastructure Errors

alter_attach_1 (x86_64):

Code: 745. DB::Exception: CPU is overloaded... (SERVER_OVERLOADED)

alter_replace (x86_64):

Code: 999. DB::Exception: Coordination::Exception: Transaction failed (No node)... (KEEPER_EXCEPTION)

Evidence: alter_replace passes on aarch64, confirming infrastructure flakiness rather than code bug.

Verdict: CI infrastructure issues (CPU exhaustion, ZooKeeper failure). Unrelated to PR changes.


3. Stateless tests (amd_asan, flaky check) - Infrastructure

Failure: failure: Start ClickHouse Server

Verdict: CI infrastructure issue during server initialization. Unrelated to PR changes.


4. Integration tests (amd_tsan, 1/6) - Flaky Test

Failure: test_system_flush_logs/test.py::test_system_logs_exists (1 of 720 tests)

Analysis: This test checks system table existence. No code path overlap with this PR's changes to KeyCondition.cpp (IN function handling) or sortBlock.cpp (debug assertion).

Verdict: Flaky test, unrelated to PR changes.


Summary

Test Category Failure Type Related to PR?
Regression (8 jobs) Pre-existing failures No
Alter tests (2 jobs) Infrastructure errors No
Flaky check Server startup No
Integration (amd_tsan, 1/6) Flaky test No

Verdict: All failures are unrelated to the PR changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

25.8.16 25.8.16 Stable 25.8.16.10001 25.8.16.10001 Stable verified Verified by QA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants