Skip to content
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

Conversation

@xsalonx
Copy link
Collaborator

@xsalonx xsalonx commented Sep 28, 2023

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • display multiple verification
  • handle flag type mixed and NoData
  • add description whether flags is from synchronous qc or asynchronous

Notable changes for developers:

  • refactor flags_view
    • code refactor
    • verification returned as single array or json's with fields by and verification_time
  • flags model modified accordingly to mentioned above
  • fix bug in pagesCellSpecials for flags
  • allow to display migrated run based flags from temporary RCT on runsPerDataPassView ONLY. If there is no flag from table quality_control_flags, then quality from Bookkeeping is displayed.

Changes made to the database:

  • NA

@xsalonx xsalonx self-assigned this Sep 28, 2023
@xsalonx xsalonx requested a review from Ehevi September 28, 2023 13:01
@xsalonx xsalonx marked this pull request as ready for review September 28, 2023 13:01
@xsalonx xsalonx requested a review from martinboulais October 4, 2023 09:25
@xsalonx xsalonx marked this pull request as draft October 5, 2023 08:46
@xsalonx xsalonx marked this pull request as ready for review October 5, 2023 11:40
@xsalonx xsalonx requested a review from martinboulais October 10, 2023 13:47
@xsalonx xsalonx merged commit 006f8f8 into master Oct 11, 2023
@xsalonx xsalonx deleted the improvement/ORCT-192/update-legacy-endpoint-to-handle-migrated-flags branch October 11, 2023 13:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants