Skip to content
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

[ORCT-118] extract find or create period #229

Merged
Ehevi merged 13 commits into from
Sep 27, 2023
Merged

[ORCT-118] extract find or create period #229

Ehevi merged 13 commits into from
Sep 27, 2023

Conversation

@xsalonx
Copy link
Collaborator

@xsalonx xsalonx commented Sep 25, 2023 •
edited
Loading

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • NA

Notable changes for developers:

  • extract common functionalities from alimionitor-services into periods service
    • move some transaction calls in order final replace them with transaction provider
  • error handlers keep more information
  • split synchronizers sequelize pipelines to smaller functions

Changes made to the database:

  • NA

@xsalonx xsalonx self-assigned this Sep 25, 2023
@xsalonx xsalonx requested a review from Ehevi September 25, 2023 13:36
@xsalonx xsalonx marked this pull request as ready for review September 25, 2023 13:36
@Ehevi Ehevi merged commit 190a754 into master Sep 27, 2023
@Ehevi Ehevi deleted the refactor/ORCT-118/extract-findOrCreatePeriod branch September 27, 2023 09:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@Ehevi Ehevi Ehevi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@xsalonx xsalonx

Labels

backend refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xsalonx @Ehevi