[ORCT-165] Data action buttons by Ehevi · Pull Request #209 · AliceO2Group/RunConditionTable · GitHub

This repository was archived by the owner on Jan 14, 2025. It is now read-only.

Collaborator

Ehevi commented Sep 6, 2023 •

edited

Loading

I have a JIRA ticket

branch and/or PR name(s) include(s) JIRA ID
issue has "Fix version" assigned
issue "Status" is set to "In review"
PR labels are selected

Notable changes for users:

hide/show button works with the periods view

Notable changes for developers:

mark the previous hide functionality (using the deprecated dataAccessModel) as obsolete

Changes made to the database:

Ehevi added frontend refactor labels

Ehevi self-assigned this

Ehevi force-pushed the feature/ORCT-165/data-action-buttons branch 2 times, most recently from 792d6e8 to bdc8aba Compare

September 14, 2023 13:49

Ehevi marked this pull request as ready for review

September 14, 2023 13:57

Ehevi requested a review from xsalonx

September 14, 2023 13:58

Ehevi force-pushed the feature/ORCT-165/data-action-buttons branch from fd2d189 to 46c50b2 Compare

September 14, 2023 15:00

xsalonx suggested changes

View reviewed changes

app/public/components/filter/filteringPanel.js Show resolved Hide resolved

app/public/model/filtering/FilterModel.js Outdated Show resolved Hide resolved

app/public/model/filtering/FilterModel.js Outdated Show resolved Hide resolved

xsalonx suggested changes

View reviewed changes

app/public/model/filtering/FilterModel.js Outdated Show resolved Hide resolved

app/public/model/filtering/FilterModel.js Outdated Show resolved Hide resolved

xsalonx suggested changes

View reviewed changes

app/public/model/filtering/FilterModel.js Outdated Show resolved Hide resolved

xsalonx suggested changes

View reviewed changes

app/public/model/filtering/FilterModel.js Outdated Show resolved Hide resolved

xsalonx reviewed

View reviewed changes

app/public/utils/filtering/filterUtils.js Outdated Show resolved Hide resolved

xsalonx suggested changes

View reviewed changes

app/public/views/periods/PeriodsModel.js Outdated Show resolved Hide resolved

Ehevi force-pushed the feature/ORCT-165/data-action-buttons branch from 46c50b2 to 9cdd76f Compare

September 22, 2023 07:58

Ehevi added 15 commits

September 22, 2023 11:18


          Data action buttons

289fc88


          Mark the previous hide buttons as obsolete

99be0fc


          Eslint cleanup 🧹

368f10e


          Unify the hideSelectedRows function

afecdcb


          Obsolete filter cleanup 🧹

06b0dfb


          Add new filtering panel

73b9c69


          Display field names in the filter panel

eb3f50c


          On filtering type change

5ccf103


          Include filter object in fetch periods request

2287eab


          Introduce filter model

102d288


          Fix typo

adc7e26


          Cleanup 🧹


          Use filterModel in the periods model

40d2f9e


          Make periods filtering work with the new API

f8b1e69


          Add filterTypesMapping

1acb0ce

Ehevi added 19 commits

September 22, 2023 11:18


          Show active filters

6c264e5


          Display ective filters

f704e3c

Fix

9a20c43


          Apply eslint rules

a78521c


          Apply eslint rules

4873fc0


          Apply eslint rules

b932b4f


          Fix hasOwnProperty bug 🐛

6ac95e2


          Cleanup 🧹

31c4f77


          Apply eslint rules

492798e


          File parser cleanup 🧹

1fdf951


          Fix typos

f4a71dc


          Cleanup 🧹

9b29aa1


          Address review comments

abb24a5


          Address review comments

53f6d87


          Remove unused getter

d00653b


          Address review comments

3b73bdc


          Address review comments

83298f9


          Cleanup 🧹

be90ee4


          Filter objects refactor

1132b72

Ehevi force-pushed the feature/ORCT-165/data-action-buttons branch from ca0b01d to 1132b72 Compare

September 22, 2023 09:18


          Split filter panel

5a786ea

Ehevi requested a review from xsalonx

September 22, 2023 09:45

xsalonx suggested changes

View reviewed changes

app/public/components/filter/filteringPanel.js Outdated Show resolved Hide resolved

app/public/components/filter/filteringPanel.js Outdated Show resolved Hide resolved

Ehevi added 2 commits

September 22, 2023 12:56


          Disable filter saving

371314d


          Apply eslint rules

6b48d6a

Ehevi requested a review from xsalonx

September 22, 2023 11:00


          Address review comments

2e532a1

xsalonx approved these changes

View reviewed changes

xsalonx merged commit 7d0693e into master

xsalonx deleted the feature/ORCT-165/data-action-buttons branch

September 22, 2023 11:04

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

frontend refactor