Skip to content
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

Conversation

@xsalonx
Copy link
Collaborator

@xsalonx xsalonx commented Aug 15, 2023

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for developers:

  • add support for ordering items in from query (ORDER BY clause in sql). Syntax: /?order[FIELD_NAME]={ASC|DESC}. Phrase can be repeated many time. e.g. /?order[runNumber]=ASC&order[timeO2Start]=DESC, what will result in sql ORDER BY run_number ASC, time_o2_start DESC. Remember that order of 'order' params in url searchParams matters.
    • ! virtual fields ordering as well as filtering is still not supported
  • introduce QueryBuilder for sequelize related functionalities

@xsalonx xsalonx requested a review from Ehevi August 15, 2023 13:37
@xsalonx xsalonx self-assigned this Aug 15, 2023
@xsalonx xsalonx marked this pull request as ready for review August 15, 2023 14:24
Copy link
Collaborator

@Ehevi Ehevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)
And we're finally above the 50% coverage! ^^

@Ehevi Ehevi merged commit 98191fb into master Aug 16, 2023
@Ehevi Ehevi deleted the feature/ORCT-152/ordering-support-on-backend branch August 16, 2023 09:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants