[ORCT-144] Update periods API by Ehevi · Pull Request #168 · AliceO2Group/RunConditionTable · GitHub

This repository was archived by the owner on Jan 14, 2025. It is now read-only.

Collaborator

Ehevi commented Aug 15, 2023 •

edited

Loading

I have a JIRA ticket

branch and/or PR name(s) include(s) JIRA ID
issue has "Fix version" assigned
issue "Status" is set to "In review"
PR labels are selected

Notable changes for users:

add year field to the periods view
add a list of distinct run energies to the period view

Notable changes for developers:

use the new API endpoint for the periods view
rename pager to obsoletePager -> from now please use the new pager only
move userPreferences up in the model hierarchy
remove unused delay function

Ehevi added frontend labels

Ehevi self-assigned this

Ehevi marked this pull request as draft

August 15, 2023 08:33

Ehevi force-pushed the feature/ORCT-144/new-api-periods branch from d4894b5 to 4b01a6a Compare

August 15, 2023 08:33

Ehevi changed the title ~~New api periods~~ [ORCT-144] Update periods API

Ehevi force-pushed the feature/ORCT-144/new-api-periods branch 3 times, most recently from 12b1dab to 4dfecfe Compare

August 16, 2023 09:49

Ehevi requested a review from xsalonx

August 16, 2023 14:45

Ehevi marked this pull request as ready for review

August 16, 2023 14:45

Ehevi commented

View reviewed changes

app/public/Model.js Show resolved Hide resolved

Ehevi commented

View reviewed changes

app/public/components/messagePanel/messages.js Show resolved Hide resolved

Ehevi commented

View reviewed changes

app/public/components/table/obsoletePager.js Show resolved Hide resolved

Ehevi commented

View reviewed changes

app/public/components/table/pagination/PaginationModel.js Show resolved Hide resolved

Ehevi commented

View reviewed changes

app/public/model/UserPreferences.js Show resolved Hide resolved

Ehevi commented

View reviewed changes

app/public/model/data/FetchedDataManager.js Show resolved Hide resolved

Ehevi commented

View reviewed changes

app/public/utils/fetch/getRemoteData.js Show resolved Hide resolved

Ehevi commented

View reviewed changes

app/public/utils/fetch/getRemoteDataSlice.js Show resolved Hide resolved

Ehevi commented

View reviewed changes

app/public/utils/fetch/jsonFetch.js Show resolved Hide resolved

Ehevi commented

View reviewed changes

app/public/views/periods/PeriodsModel.js Show resolved Hide resolved

Ehevi commented

View reviewed changes

app/public/views/periods/overview/periodsContent.js Show resolved Hide resolved

Ehevi commented

View reviewed changes

app/public/views/periods/table/periodsTableHeader.js Show resolved Hide resolved

Ehevi force-pushed the feature/ORCT-144/new-api-periods branch 2 times, most recently from 47afa6e to 500ad50 Compare

August 24, 2023 09:38

Ehevi force-pushed the feature/ORCT-144/new-api-periods branch from 042f065 to a8569ec Compare

August 25, 2023 14:26

Ehevi added 4 commits

August 25, 2023 17:59


          New api periods


          Apply eslint rules ✨

073fef1


          Use message panels

f2b237b


          Messages

c3df896

Ehevi added 20 commits

August 25, 2023 17:59


          Cleanup 🧹

fdf8618


          Tests cleanup 🧹

7ea3ace


          Enum content types

66529b0


          Add CSV data preparation test

ca85ace


          Remove console logs

809176a


          Fix dataExport modal rendering condition

4fdc9b5


          Address review comments

8c4d9d7


          Address review comments

e3e30a7


          Remove capitalizeFirstLetter function

f4aa38e


          Newlines

6950d88


          Pagename tests

489c1d6


          Cleanup 🧹

ac25f2f


          Sort cleanup

85bb90a


          Address review comments

c2e7267


          Address review comments

ad73985


          Move pageTitle to separate component


          Chai export cleanup 🧹

4a06657


          Tests cleanup 🧹

d25936a


          Tests cleanup 🧹

9c58165


          Cleanup 🧹

9cee950

Ehevi force-pushed the feature/ORCT-144/new-api-periods branch from a8569ec to 9cee950 Compare

August 25, 2023 15:59

xsalonx suggested changes

View reviewed changes

app/public/components/table/pageSelector.js Outdated Show resolved Hide resolved

app/public/utils/fetch/jsonFetch.js Outdated Show resolved Hide resolved

app/public/views/periods/overview/dataExport.js Outdated Show resolved Hide resolved

app/public/views/periods/overview/dataExport.js Outdated Show resolved Hide resolved

test/public/components/itemsCounter.test.js Outdated Show resolved Hide resolved

Ehevi added 4 commits

August 28, 2023 13:27


          Address review comments

d078ce2


          Address review comments

a83b26e


          Address review comments

da57811


          Address review comments

3f8bd44

Ehevi requested a review from xsalonx

August 28, 2023 11:34

xsalonx approved these changes

View reviewed changes

xsalonx merged commit 7f856d9 into master

xsalonx deleted the feature/ORCT-144/new-api-periods branch

August 28, 2023 11:35

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet