This repository was archived by the owner on Jan 14, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
[ORCT0-134] - filtering for new api #148
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ehevi
reviewed
Aug 2, 2023
Ehevi
reviewed
Aug 2, 2023
479068b to
f8dfd48
Compare
f8dfd48 to
906cbb4
Compare
Ehevi
approved these changes
Aug 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a JIRA ticket
Notable changes for users:
Example:
Client use url:
The url will be parsed by qs in express to:
query.filter is being passed as an argument to filterToSequelizeWhereClause function
which returns sequelize-compatible where-clause
What is equivalent to sql:
##!!! For entity Run filtering with columns runDuration, endTime, startTime is not supported because they are virtual fields, which with sequelize quering is not possible
Notable changes for developers:
filterToSequelizeWhereClausevalidateDTOrenamed tovalidateDtoOrRepondOnFailureSTDEntiryDTOrenamed tostdDataRequestDTOcontrollerHandlerWrapperfor handling all uncaught errors during processing clients requests