Skip to content
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

Conversation

@xsalonx
Copy link
Collaborator

@xsalonx xsalonx commented Jul 27, 2023

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for developers:

  • removed pipeline 'test', now there is 'coverage' and 'static-analysis'

  • docker related files simplified

  • running tests on docker using npm run test (not docker:test)

    • command exit with status code of command running tests inside docker npm run coverage
  • container names changed (depends on context dev or test):

    • o2-rct_application -> o2rct_application-dev or o2rct_application-test
    • o2-rct_database -> o2rct_database-dev or o2rct_database-test
  • rctmake update:

    • stage build renamed to run
    • usage update

@xsalonx xsalonx requested a review from Ehevi July 27, 2023 10:41
@xsalonx xsalonx marked this pull request as draft July 27, 2023 10:44
@xsalonx xsalonx marked this pull request as ready for review July 27, 2023 10:49
@Ehevi
Copy link
Collaborator

Ehevi commented Jul 27, 2023

Coverage keeps failing because it can't find docker:test script.

@xsalonx xsalonx marked this pull request as draft July 27, 2023 12:50
@xsalonx xsalonx marked this pull request as ready for review July 27, 2023 14:29
@xsalonx xsalonx self-assigned this Jul 28, 2023
@Ehevi Ehevi merged commit 612aa2b into master Jul 28, 2023
@Ehevi Ehevi deleted the improvement/ORCT-130/dockers-dev-test-separation branch July 28, 2023 07:42
@xsalonx xsalonx mentioned this pull request Jul 28, 2023
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants