ORCT-97 Add link to the BK fill page #134

Ehevi · 2023-07-25T09:08:13Z

I have a JIRA ticket

branch and/or PR name(s) include(s) JIRA ID
issue has "Fix version" assigned
issue "Status" is set to "In review"
PR labels are selected

Notable changes for users:

clicking on the fill number in the runs view will take the user to the BK fill page
more intuitive link share icon
display snackbar after copying the url

Notable changes for developers:

copyLinkButton made a separate component
rename PrimaryModel to DataAccessModel
make title component model independent and move it to the components directory

app/public/utils/dataProcessing/dataProcessingUtils.js

app/public/components/chips/indexChip.js

app/public/Model.js

app/public/components/buttons/copyLinkButton.js

app/public/components/chips/indexChip.js

app/public/Model.js

app/public/components/chips/indexChip.js

app/public/model/data/FetchedDataManager.js

app/public/components/table/title.js

app/public/model/navigation/Navigation.js

app/public/utils/filtering/filterUtils.js

app/public/views/flags/overview/flagsContent.js

app/public/views/runs/runsPerDataPass/overview/content.js

app/public/components/chips/indexChip.js

app/public/views/userView/data/pagesCellsSpecials.js

app/public/model/navigation/Navigation.js

app/public/components/buttons/copyLinkButton.js

app/public/views/userView/data/table/tablePanel.js

app/public/views/flags/overview/flagsContent.js

app/config/public.js

ORCT-97-fills

01f44ee

Ehevi added enhancement labels Jul 25, 2023

Ehevi self-assigned this Jul 25, 2023

Ehevi marked this pull request as ready for review July 25, 2023 09:09

Ehevi requested a review from xsalonx July 25, 2023 09:09

Ehevi added 18 commits July 25, 2023 11:28

Change share link icon

81b1a0c

Make copyLinkButton a separate component

59d415d

Snackbar

cfc5f43

Flex row gap

977a334

Link icon

6b8c371

Rename PrimaryModel

fd619df

Use default rows on site parameter

747ed91

Data access

27d69cf

indexChip cleanup 🧹

dd01ca0

Apply eslint rules

91e2327

Rename Navigation Model

635128b

Fix

8ce0b55

Fix flags index chips

c875101

Test

618b3c4

Make title model independent

510b304

Move title to the components catalog

e03a079

Clear filters cleanup

4415e03

Use navigation model

027eadd

xsalonx suggested changes Jul 25, 2023

View reviewed changes

app/public/utils/dataProcessing/dataProcessingUtils.js Outdated Show resolved Hide resolved

Address review comments

b95d3c7

Ehevi requested a review from xsalonx July 25, 2023 14:29

xsalonx reviewed Jul 25, 2023

View reviewed changes

app/public/components/chips/indexChip.js Outdated Show resolved Hide resolved

Ehevi added 2 commits July 25, 2023 16:55

Address review comments

d68d96e

Apply review comments

7cc122c

xsalonx suggested changes Jul 25, 2023

View reviewed changes

app/public/Model.js Outdated Show resolved Hide resolved

app/public/components/buttons/copyLinkButton.js Show resolved Hide resolved

app/public/components/chips/indexChip.js Show resolved Hide resolved

xsalonx suggested changes Jul 25, 2023

View reviewed changes

app/public/Model.js Outdated Show resolved Hide resolved

Ehevi added 3 commits July 25, 2023 17:04

Address review comments

d793c65

Mode name

d7750ba

Address review comments

f238231

xsalonx suggested changes Jul 25, 2023

View reviewed changes

app/public/components/chips/indexChip.js Show resolved Hide resolved

app/public/model/data/FetchedDataManager.js Outdated Show resolved Hide resolved

Ehevi added 6 commits July 26, 2023 09:43

Fix model mode name

d692dcc

Fix waiting panel bug 🐛

90c6d6f

Remove unused files

5a7b6ba

IndexChip cleanup 🧹

0c9a07a

Address review comments

b3ed409

Apply eslint rules

86768da

Ehevi requested a review from xsalonx July 26, 2023 08:37

xsalonx suggested changes Jul 26, 2023

View reviewed changes

Ehevi added 5 commits July 26, 2023 11:10

Address review comments

32df041

Change noRunNumbers variable name

62cb31c

Address review comments

9cd038a

JS docs

221cdb8

Address review comments

00be7ff

Ehevi requested a review from xsalonx July 26, 2023 10:33

Ehevi added 3 commits July 26, 2023 13:49

Address review comments

579f67b

Address review comments

66dc725

Address review comments

2b14512

xsalonx approved these changes Jul 26, 2023

View reviewed changes

app/public/views/flags/overview/flagsContent.js Outdated Show resolved Hide resolved

app/config/public.js Outdated Show resolved Hide resolved

xsalonx merged commit fdc25a6 into master Jul 26, 2023

xsalonx deleted the feature/ORCT-97-fills branch July 26, 2023 11:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ORCT-97 Add link to the BK fill page #134

ORCT-97 Add link to the BK fill page #134

Uh oh!

Ehevi commented Jul 25, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ORCT-97 Add link to the BK fill page #134

ORCT-97 Add link to the BK fill page #134

Uh oh!

Conversation

Ehevi commented Jul 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I have a JIRA ticket

Notable changes for users:

Notable changes for developers:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Ehevi commented Jul 25, 2023 •

edited

Loading