Merged
Conversation
7e8d989 to
313a24f
Compare
e22b05b to
3669525
Compare
jeffctown
approved these changes
Oct 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
I've added a matcher called
hasFormBodythat tests whether theNSURLRequestcontent-type isapplication/x-www-form-urlencodedand body contains query parameters.Motivation and Context
In POST request with
application/x-www-form-urlencoded, parameters are handled in httpBody.For that reason,
containsQueryParamsfunction is useless for this situation.Also for the same reason as #265, I need a new matcher that takes query items from httpBody and matches with expected pairs.