Skip to content

472 grb set does not execute in parallel#35

Merged
anyzelman merged 4 commits intodevelopfrom
472-grb-set-does-not-execute-in-parallel
Aug 5, 2022
Merged

472 grb set does not execute in parallel#35
anyzelman merged 4 commits intodevelopfrom
472-grb-set-does-not-execute-in-parallel

Conversation

@anyzelman
Copy link
Member

@anyzelman anyzelman commented Aug 5, 2022

This MR contains the following changes:

  • bugfix: an earlier MR moved the grb::set functions of the reference and reference_omp backends to reference/io.cpp, but did not update the parallelisation guards.
  • code improvement: rely on config::OMP::localRange instead of parallel-for with a chunked static schedule. In several cases related to calls to grb::set and vector construction this leads to significant speedups.

This resolves internal issue 472 and contributes to internal issue 479.

Thanks to Alberto Scolari for contributing!

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant