Skip to content

fix: memory leak when toggling search panel #1808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RohitKushvaha01 merged 2 commits into from
Jan 11, 2026
+4 −1
Merged

fix: memory leak when toggling search panel #1808

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e86f9f4
fix: memory leak when toggling search panel
RohitKushvaha01 Jan 11, 2026
e345c7c
format
RohitKushvaha01 Jan 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/handlers/quickTools.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,11 @@ appSettings.on("update:quicktoolsItems:after", () => {
}, 100);
});

let historyNavigationInitialized = false;
// Initialize history navigation
function setupHistoryNavigation() {
if (historyNavigationInitialized) return;
historyNavigationInitialized = true;
const { $searchInput, $replaceInput } = quickTools;

// Search input history navigation
Expand All @@ -87,7 +90,7 @@ function setupHistoryNavigation() {
e.preventDefault();
const { editor, activeFile } = editorManager;
editor.focus();
toggleSearch();
actionStack.get("search-bar")?.action();
} else if (e.key === "ArrowUp") {
e.preventDefault();
const newValue = searchHistory.navigateSearchUp($searchInput.el.value);
Expand Down