Skip to content

Draft: relation inside metadata group in refer crosswalk#387

Draft
floriangantner wants to merge 4 commits into4Science:dspace-cris-2023_02_xfrom
uniba-ub:dspace-cris-7-relationmetadatagroup
Draft

Draft: relation inside metadata group in refer crosswalk#387
floriangantner wants to merge 4 commits into4Science:dspace-cris-2023_02_xfrom
uniba-ub:dspace-cris-7-relationmetadatagroup

Conversation

@floriangantner
Copy link

References

Description

extension of refercrosswalk to consider relation inside metadatagroup.

Instructions for Reviewers

Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.

List of changes in this PR:

  • added check/line, if some value is some placeholder if.nullorplaceholder. or if.not.nullorplaceholder
  • extended group to consider if conditions and to consider relation to other items inside the group.

Some example template considering both changes above configuration might be:

   <Authors>
        @group.dc-contributor-author.start@
            <Author>
                <DisplayName>@dc.contributor.author@</DisplayName>
                @relation.dc-contributor-author.start@
                    <Person id="@virtual.id@">
                    	<PersonName>
                    		<FamilyNames>@virtual.personName.lastName@</FamilyNames>
                    		<FirstNames>@virtual.personName.firstName@</FirstNames>
                    	</PersonName>
		                <ORCID>https://orcid.org/@person.identifier.orcid@</ORCID>
	            </Person>
                @relation.dc-contributor-author.end@
                @if.not.nullorplaceholder.oairecerif-author-affiliation.start@
                    @relation.oairecerif-author-affiliation.start@
                        <Affiliation>
                            <OrgUnit id="@virtual.id@">
                            @if.metadata.dc-title.start@
                                <Name>@dc.title@</Name>
                            @if.metadata.dc-title.end@
                            @if.metadata.organization-identifier-ror.start@
                            	<RORID>@organization.identiifer.ror@</RORID>
                            @if.metadata.organization-identifier-ror.end@
                            @if.metadata.organization-identifier-crossrefid.start@
                                <FundRefID>https://doi.org/10.13039/@organization.identifier.crossrefid@</FundRefID>
                            @if.metadata.organization-identifier-crossrefid.end@
                            </OrgUnit>
                        </Affiliation>
                    @relation.oairecerif-author-affiliation.end@
                @if.not.nullorplaceholder.oairecerif-author-affiliation.end@
            </Author>
	  	@group.dc-contributor-author.end@
	</Authors>

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
  • My PR passes Checkstyle validation based on the Code Style Guide.
  • My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
  • My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR modifies REST API endpoints, I've opened a separate REST Contract PR related to this change.
  • If my PR includes new configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@floriangantner
Copy link
Author

aligned to 2023.02.02 Release

@floriangantner floriangantner changed the base branch from dspace-cris-7 to main-cris February 21, 2024 14:35
@floriangantner floriangantner changed the base branch from main-cris to dspace-cris-2023_02_x April 9, 2024 09:58
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had
activity in one year. It will be closed in 14 days if no further activity occurs.

Allowing pull requests to close as stale helps us filter out old work that is no longer
relevant and helps developers focus on reviewing current work.

All pull requests closed by this bot act like normal pull requests;
they can be searched for, commented on or reopened at any point.

If these changes are still relevant then please comment and/or rebase your PR based on the
latest DSpace code. This will remove the stale status and notify us to assign a reviewer
for your PR.

@github-actions github-actions bot added the stale label Feb 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

handle relation inside group in refercrosswalk

1 participant