Fixes foreach order when --topological isnt set (#6997)

## What's the problem this PR addresses?

The traversal order when `--topological` isn't set can be unpredictable.

## How did you fix it?

Workspaces are now sorted by their idents. To make them topological, the
`--topological` flag must be set.

## Checklist

<!--- Don't worry if you miss something, chores are automatically
tested. -->
<!--- This checklist exists to help you remember doing the chores when
you submit a PR. -->
<!--- Put an `x` in all the boxes that apply. -->
- [x] I have read the [Contributing
Guide](https://yarnpkg.com/advanced/contributing).

<!-- See
https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released
for more details. -->
<!-- Check with `yarn version check` and fix with `yarn version check
-i` -->
- [x] I have set the packages that need to be released for my changes to
be effective.

<!-- The "Testing chores" workflow validates that your PR follows our
guidelines. -->
<!-- If it doesn't pass, click on it to see details as to what your PR
might be missing. -->
- [x] I will check that all automated PR checks pass before the PR gets
reviewed.

Author: arcanis

.yarn/versions/d07cb1af.yml

@@ -0,0 +1,23 @@
+releases:
+  "@yarnpkg/cli": patch
+  "@yarnpkg/plugin-workspace-tools": patch
+
+declined:
+  - "@yarnpkg/plugin-compat"
+  - "@yarnpkg/plugin-constraints"
+  - "@yarnpkg/plugin-dlx"
+  - "@yarnpkg/plugin-essentials"
+  - "@yarnpkg/plugin-init"
+  - "@yarnpkg/plugin-interactive-tools"
+  - "@yarnpkg/plugin-nm"
+  - "@yarnpkg/plugin-npm-cli"
+  - "@yarnpkg/plugin-pack"
+  - "@yarnpkg/plugin-patch"
+  - "@yarnpkg/plugin-pnp"
+  - "@yarnpkg/plugin-pnpm"
+  - "@yarnpkg/plugin-stage"
+  - "@yarnpkg/plugin-typescript"
+  - "@yarnpkg/plugin-version"
+  - "@yarnpkg/builder"
+  - "@yarnpkg/core"
+  - "@yarnpkg/doctor"

packages/acceptance-tests/pkg-tests-core/sources/utils/tests.ts

@@ -29,16 +29,18 @@ const staticServer = serveStatic(npath.fromPortablePath(require(`pkg-tests-fixtu
 
 const TEST_MAJOR = process.env.TEST_MAJOR
   ? parseInt(process.env.TEST_MAJOR, 10)
-  : null;
+  : 4;
 
-function isAtLeastMajor(major: number) {
-  return TEST_MAJOR !== null && TEST_MAJOR >= major;
+function majorCheck(test: (major: number) => boolean) {
+  return TEST_MAJOR === null || test(TEST_MAJOR);
 }
 
 export const FEATURE_CHECKS = {
-  jsonLockfile: isAtLeastMajor(5),
-  prologConstraints: !isAtLeastMajor(5),
-  mergeConflictTheirs: isAtLeastMajor(5),
+  forEachWorktree: majorCheck(major => major <= 4),
+  forEachVerboseDone: majorCheck(major => major >= 5),
+  jsonLockfile: majorCheck(major => major >= 5),
+  prologConstraints: majorCheck(major => major <= 4),
+  mergeConflictTheirs: majorCheck(major => major >= 5),
 } as const;
 
 // Testing things inside a big-endian container takes forever