Skip to content

wp-cli-comform command#705

Merged
frankiejarrett merged 5 commits intoxwp:developfrom
szepeviktor:develop
Apr 2, 2015
Merged

wp-cli-comform command#705
frankiejarrett merged 5 commits intoxwp:developfrom
szepeviktor:develop

Conversation

@szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Feb 25, 2015

Adding line comments...

szepeviktor
szepeviktor reviewed Feb 25, 2015
View reviewed changes
includes/wp-cli.php
Copy link
Contributor Author

@szepeviktor szepeviktor Feb 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only one

szepeviktor
szepeviktor reviewed Feb 25, 2015
View reviewed changes
includes/wp-cli.php
Copy link
Contributor Author

@szepeviktor szepeviktor Feb 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed timer, a wp-cli user is advanced enough to know what is happening, and why it takes time

Copy link
Contributor

@frankiejarrett frankiejarrett Apr 2, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@szepeviktor Fair enough. Better results can be seen with the time command anyway.

$ time wp stream query

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Feb 25, 2015

This must have an least one error. Please review.

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Feb 25, 2015

Has a very nice output. Do you need csv, json and count output?

+------------------------------+----------------+--------+------------------------+---------------+------------------------------------+
| created                      | ip             | author | author_meta.user_login | author_role   | summary                            |
+------------------------------+----------------+--------+------------------------+---------------+------------------------------------+
| 2015-02-25T18:07:20.709+0000 | 192.168.12.146 | 1      | viktor                 | administrator | "1" post published                 |
| 2015-02-25T18:07:18.045+0000 | 192.168.12.146 | 1      | viktor                 | administrator | "1" post drafted                   |
| 2015-02-25T18:04:51.063+0000 | 192.168.12.146 | 1      | viktor                 | administrator | "What's running" plugin activated  |
| 2015-02-25T18:04:01.200+0000 | 192.168.12.146 | 1      | viktor                 | administrator | Site connected to Stream           |
+------------------------------+----------------+--------+------------------------+---------------+------------------------------------+

*included

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Feb 25, 2015

I am OK if you reject it. It could also be a separate wp-cli community command.
I've done these modifications based on the wp-cli contributor experience.
I hope it will not hurt any of you.

@szepeviktor szepeviktor mentioned this pull request Feb 25, 2015
Closed
@frankiejarrett
Copy link
Contributor

frankiejarrett commented Mar 12, 2015

@szepeviktor Just a few CI errors to take note of: https://travis-ci.org/wp-stream/stream/jobs/52189700#L890

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Mar 12, 2015

Was it CodeSniffer?

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Mar 12, 2015

I've done it for free. Could you give me a trial PRO licence?

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Mar 12, 2015

All green.

@frankiejarrett
Copy link
Contributor

frankiejarrett commented Mar 12, 2015

Thanks @szepeviktor. We are using the WordPress Coding Standards project to enforce coding style, which uses PHP_CodeSniffer.

Absolutely, please e-mail me your Stream Site ID frankie@wp-stream.com

@szepeviktor szepeviktor mentioned this pull request Apr 2, 2015
Closed
frankiejarrett added a commit that referenced this pull request Apr 2, 2015
@frankiejarrett
Merge pull request #705 from szepeviktor/develop
147029d 
wp-cli-comform command
@frankiejarrett frankiejarrett merged commit 147029d into xwp:develop Apr 2, 2015
@frankiejarrett
Copy link
Contributor

frankiejarrett commented Apr 2, 2015

@szepeviktor Nicely done! Thanks for these many improvements. Please do shoot me an email when you can.

szepeviktor referenced this pull request Apr 3, 2015
@frankiejarrett
Add support for --format flag, which can be table, json or json_pretty
0a84082
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@szepeviktor @frankiejarrett