PumpManagers must be able to recommend supported TB and Bolus amounts#6
Merged
PumpManagers must be able to recommend supported TB and Bolus amounts#6
Conversation
darinkrauss
approved these changes
Mar 8, 2019
darinkrauss
left a comment
darinkrauss
left a comment
There was a problem hiding this comment.
One question and a couple nits for your consideration.
LoopKit/PumpManager.swift
Outdated
| var maximumBolusVolume: Double { get } | ||
|
|
||
| // Maximum pump allowed basal rate in U/Hr | ||
| var maximumBasalRate: Double { get } |
There was a problem hiding this comment.
[nit] I would move this just below supportedBasalRates so you have supported/maximum for basal rates, and then supported/maximum for bolus volumes.
LoopKit/PumpManager.swift
Outdated
| var supportedBolusVolumes: [Double] { get } | ||
|
|
||
| // Maximum pump allowed bolus volume in U | ||
| var maximumBolusVolume: Double { get } |
There was a problem hiding this comment.
Will a pump always have supported(BasalRates/BolusVolumes)? If so, then is there a need for maximum(BasalRate/BolusVolume)? Wouldn't the maximum just be dictated by the supported values?
LoopKit/PumpManager.swift
Outdated
| /// - Parameters: | ||
| /// - unitsPerHour: A desired rate of delivery in Units/hr | ||
| /// - Returns: a supported rate of delivery in Units/hr. The rate returned should not be larger than the passed in rate. | ||
| func roundToSupportedTemporaryBasalRate(unitsPerHour: Double) -> Double |
There was a problem hiding this comment.
[nit] Remove the "Temporary" aspect here. Just roundToSupportedBasalRate for consistency.
ps2
pushed a commit
that referenced
this pull request
Apr 21, 2023
* Add unannounced meal func to CarbStoreProtocol * V1 of UAM algo * Fix issues with time intervals not lining up * Fix issue with ICE not being cumulative * Make carb threshold a static const * Handle errors in fetching glucose effects * Add date range unit test * Style improvement * Update build settings so watch can access LoopNotificationUserInfoKey * Add debug info for feature to carbstore * Remove unneeded variable set * Save last UAM notification time in UserDefaults * Add debug info * Update naming to make constant transition easier * Use constants instead of variables * Only restrict notification delivery so we don't detect the same meal twice * Retract UAM notifications after the carbs have expired * Simplify change & meal checks into a single threshold * Fix effects from outside of the search window being included & triggering false-positive UAM detections * Improve function naming * Add enhanced debug info * Move notification logic from LoopKit to Loop * Improve debug logs * Make current date configurable * Add preliminary tests * Add test * Fix carb entries being purged bc of current date not being set during unit testing * Update UAM tests * Update status enum naming for point-of-use clarity * Fix observation start for unit testing * Pull UAM constants into separate struct * Fix unexpected effect not including all needed effects * Fix carb effects not being carb _counteraction_ effects * Update tests for algo changes * Add noisy cgm testcase * Add test for non-unannounced meal with COB * Add realistic unannounced meal test * Improve algo commenting * Update UAM algo to detect more-aggressively * Remove TODO * Update debug information * Schedule missed meal notifications to avoid notification during an microbolus (#2) * Add ability to estimate delivery duration of bolus * Add tests for UAM notification delay * Update `estimatedDuration` function headers in response to PR feedback * Add UAM banner to carb entry screen (#4) * UAM algo updates: only use directly observed carb absorption (#5) * Add ability to calculate the number of carbs in a missed meal (#3) * Plumb a customizable carb amount through UAM notification architecture * Refactor carb effect threshold computation into helper function * Add first draft of dynamic carb selection for meal * Bump max carb autofill limit from 100 -> 150 * Add tests for carb autofill * Bump max carb threshold limit because of dynamic autofill clamping * Lower the UAM max autofill * Require that unannounced meals have ICE onboard that is >= the meal threshold, and only autofill observed ICE * Lower ICE threshold for a UAM notification * Update tests * Improve debug info * Update commenting * Remove unused test * Update test * `dateRange` -> `simulationDateRange` * Create `MealDetectionManager` from old UAM functions in `CarbStore` * Add fixme * Updates based on feedback for UAM PR (#6) * `dateRange` -> `simulationDateRange` * Create `MealDetectionManager` from old UAM functions in `CarbStore` * Add fixme * Move UAM test fixtures from LoopKit to Loop * Unannounced meal / UAM -> missed meal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.