Merge pull request #798 from hofi1/bugfix/fix-XML-flacky-test

stleary · web-flow · commit d677a99f4ef5 · 2023-10-17T13:52:29.000-05:00
fix: flakiness in org.json.junit.XMLTest#testIndentComplicatedJsonObjectWithArrayAndWithConfig
diff --git a/src/test/java/org/json/junit/XMLTest.java b/src/test/java/org/json/junit/XMLTest.java
@@ -1234,7 +1234,7 @@ public void testIndentComplicatedJsonObjectWithArrayAndWithConfig(){
                 for (int numRead; (numRead = in.read(buffer, 0, buffer.length)) > 0; ) {
                     expected.append(buffer, 0, numRead);
                 }
-                assertEquals(expected.toString(), actualString);
+                assertTrue(XML.toJSONObject(expected.toString()).similar(XML.toJSONObject(actualString)));
             }
         } catch (IOException e) {
             fail("file writer error: " +e.getMessage());

Original file line number	Diff line number	Diff line change
`@@ -1234,7 +1234,7 @@ public void testIndentComplicatedJsonObjectWithArrayAndWithConfig(){`
`1234`	`1234`	`for (int numRead; (numRead = in.read(buffer, 0, buffer.length)) > 0; ) {`
`1235`	`1235`	`expected.append(buffer, 0, numRead);`
`1236`	`1236`	`}`
`1237`		`- assertEquals(expected.toString(), actualString);`
	`1237`	`+ assertTrue(XML.toJSONObject(expected.toString()).similar(XML.toJSONObject(actualString)));`
`1238`	`1238`	`}`
`1239`	`1239`	`} catch (IOException e) {`
`1240`	`1240`	`fail("file writer error: " +e.getMessage());`