Skip to content

Commit e1004e8

Browse files
authored
Merge pull request #42 from sinricpro/2.6.2
2.6.2 - Fix NoneType object is not callable
2 parents 5c13f9a + fdeb715 commit e1004e8

File tree

4 files changed

+17
-43
lines changed

4 files changed

+17
-43
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
## [2.6.2]
2+
3+
### Bugfix
4+
* **'NoneType' object is not callable**
5+
16
## [2.6.1]
27

38
### Features

setup.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
if sys.version_info < (3,6):
1111
sys.exit('Sorry, Python < 3.6 is not supported')
1212

13-
VERSION = "2.6.1"
13+
VERSION = "2.6.2"
1414

1515
with open('README.rst', 'r') as f:
1616
long_description = f.read()
@@ -26,8 +26,7 @@
2626
url="https://github.com/sinricpro/python-sdk",
2727
packages=['sinric'],
2828
install_requires=["websockets==10.1","loguru"],
29-
keywords=['alexa', 'alexa-skill', 'sinric', 'sinric-alexa-skill', 'alexa-home-automation', 'sinric-pro',
30-
'sinric-pro-alexa-skill'],
29+
keywords=['sinric', 'sinric-pro'],
3130
classifiers=[
3231
"Programming Language :: Python :: 3",
3332
"Operating System :: OS Independent",

sinric/_cbhandler.py

Lines changed: 5 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -251,8 +251,6 @@ def jsnHandle(action, resp, dataDict, instanceId='') -> dict:
251251
except Exception as e:
252252
self.logger.error(str(e))
253253

254-
255-
256254
elif jsn.get('payload').get('action') == JSON_COMMANDS.get('ADJUSTRANGEVALUE'):
257255
try:
258256
assert (self.verifySignature(jsn.get('payload'), jsn.get("signature").get("HMAC")))
@@ -300,7 +298,6 @@ def jsnHandle(action, resp, dataDict, instanceId='') -> dict:
300298
except Exception as e:
301299
self.logger.error(str(e))
302300

303-
304301
elif jsn.get('payload').get('action') == JSON_COMMANDS.get('SETVOLUME'):
305302
try:
306303
assert (self.verifySignature(jsn.get('payload'), jsn.get("signature").get("HMAC")))
@@ -317,8 +314,6 @@ def jsnHandle(action, resp, dataDict, instanceId='') -> dict:
317314
except Exception as e:
318315
self.logger.error(str(e))
319316

320-
321-
322317
elif jsn.get('payload').get('action') == 'adjustVolume':
323318
try:
324319
assert (self.verifySignature(jsn.get('payload'), jsn.get("signature").get("HMAC")))
@@ -335,8 +330,6 @@ def jsnHandle(action, resp, dataDict, instanceId='') -> dict:
335330
except Exception as e:
336331
self.logger.error(str(e))
337332

338-
339-
340333
elif jsn.get('payload').get('action') == 'mediaControl':
341334
try:
342335
assert (self.verifySignature(jsn.get('payload'), jsn.get("signature").get("HMAC")))
@@ -365,7 +358,6 @@ def jsnHandle(action, resp, dataDict, instanceId='') -> dict:
365358
except Exception as e:
366359
self.logger.error(str(e))
367360

368-
369361
elif jsn.get('payload').get('action') == 'changeChannel':
370362
try:
371363
assert (self.verifySignature(jsn.get('payload'), jsn.get("signature").get("HMAC")))
@@ -383,7 +375,6 @@ def jsnHandle(action, resp, dataDict, instanceId='') -> dict:
383375
except Exception as e:
384376
self.logger.error(str(e))
385377

386-
387378
elif jsn.get('payload').get('action') == 'skipChannels':
388379
try:
389380
assert (self.verifySignature(jsn.get('payload'), jsn.get("signature").get("HMAC")))
@@ -456,7 +447,6 @@ def jsnHandle(action, resp, dataDict, instanceId='') -> dict:
456447
except Exception as e:
457448
self.logger.error(str(e))
458449

459-
460450
elif jsn.get('payload').get('action') == 'resetBands':
461451
try:
462452
assert (self.verifySignature(jsn.get('payload'), jsn.get("signature").get("HMAC")))
@@ -482,10 +472,7 @@ def jsnHandle(action, resp, dataDict, instanceId='') -> dict:
482472
self.logger.error("Signature verification failed for " + jsn.get('payload').get('action'))
483473
except Exception as e:
484474
self.logger.error(str(e))
485-
486-
487-
488-
475+
489476
elif jsn.get('payload').get('action') == 'setMode':
490477
try:
491478
assert (self.verifySignature(jsn.get('payload'), jsn.get("signature").get("HMAC")))
@@ -500,8 +487,7 @@ def jsnHandle(action, resp, dataDict, instanceId='') -> dict:
500487
self.logger.error("Signature verification failed for " + jsn.get('payload').get('action'))
501488
except Exception as e:
502489
self.logger.error(str(e))
503-
504-
490+
505491
elif jsn.get('payload').get('action') == 'setLockState':
506492
try:
507493
assert (self.verifySignature(jsn.get('payload'), jsn.get("signature").get("HMAC")))
@@ -517,117 +503,98 @@ def jsnHandle(action, resp, dataDict, instanceId='') -> dict:
517503
except Exception as e:
518504
self.logger.error(str(e))
519505

520-
############################ EVENTS ###########################################################
506+
############################ EVENTS ###########################################################
521507

522508
if Trace == 'doorbell_event_response':
523509
if self.bucket.addDrop():
524510
self.logger.info('Sending Doorbell Event Response')
525511
await connection.send(dumps(jsn))
526512

527-
528513
elif Trace == 'temp_hum_event_response':
529514
if self.bucket.addDrop():
530515
self.logger.info('Sending temperature humidity response')
531516
await connection.send(dumps(jsn))
532517

533-
534518
elif Trace == 'setpowerstate_event_response':
535519
if self.bucket.addDrop():
536520
self.logger.info('Sending setpowerstate_event_response')
537521
await connection.send(dumps(jsn))
538522

539-
540523
elif Trace == 'setPowerLevel_event_response':
541524
if self.bucket.addDrop():
542525
self.logger.info('Sending setPowerLevel_event_response')
543526
await connection.send(dumps(jsn))
544527

545-
546528
elif Trace == 'setBrightness_event_response':
547529
if self.bucket.addDrop():
548530
self.logger.info('Sending setBrightness_event_response')
549531
await connection.send(dumps(jsn))
550532

551-
552533
elif Trace == 'setColor_event_response':
553534
if self.bucket.addDrop():
554535
self.logger.info('Sending setColor_event_response')
555536
await connection.send(dumps(jsn))
556537

557-
558538
elif Trace == 'setColorTemperature_event_response':
559539
if self.bucket.addDrop():
560540
self.logger.info('Sending setColorTemperature_event_response')
561541
await connection.send(dumps(jsn))
562542

563-
564543
elif Trace == 'setThermostatMode_event_response':
565544
if self.bucket.addDrop():
566545
self.logger.info('Sending setThermostatMode_event_response')
567546
await connection.send(dumps(jsn))
568547

569-
570548
elif Trace == 'setRangeValue_event_response':
571549
if self.bucket.addDrop():
572550
self.logger.info('Sending setRangeValue_event_response')
573551
await connection.send(dumps(jsn))
574552

575-
576553
elif Trace == 'motion_event_response':
577554
if self.bucket.addDrop():
578555
self.logger.info('Sending motion_event_response')
579556
await connection.send(dumps(jsn))
580557

581-
582558
elif Trace == 'contact_event_response':
583559
if self.bucket.addDrop():
584560
self.logger.info('Sending contact_event_response')
585561
await connection.send(dumps(jsn))
586562

587-
588563
elif Trace == 'set_volume_event_response':
589564
if self.bucket.addDrop():
590565
self.logger.info('Sending set_volume_event_response')
591566
await connection.send(dumps(jsn))
592567

593-
594568
elif Trace == 'select_input_event_response':
595569
if self.bucket.addDrop():
596570
self.logger.info('Sending select_input_event_response')
597571
await connection.send(dumps(jsn))
598572

599-
600573
elif Trace == 'media_control_event_response':
601574
if self.bucket.addDrop():
602575
self.logger.info('Sending media_control_event_response')
603576
await connection.send(dumps(jsn))
604577

605-
606578
elif Trace == 'change_channel_event_response':
607579
if self.bucket.addDrop():
608580
self.logger.info('Sending change_channel_event_response')
609581
await connection.send(dumps(jsn))
610582

611-
612583
elif Trace == 'set_bands_event_response':
613584
if self.bucket.addDrop():
614585
self.logger.info('Sending set_bands_event_response')
615586
await connection.send(dumps(jsn))
616587

617-
618-
619588
elif Trace == 'set_mode_event_response':
620589
if self.bucket.addDrop():
621590
self.logger.info('Sending set_mode_event_response')
622591
await connection.send(dumps(jsn))
623592

624-
625593
elif Trace == 'set_lock_event_response':
626594
if self.bucket.addDrop():
627595
self.logger.info('Sending set_lock_event_response')
628596
await connection.send(dumps(jsn))
629597

630-
631598
elif Trace == 'reset_bands_event_response':
632599
if self.bucket.addDrop():
633600
self.logger.info('Sending reset_bands_event_response')
@@ -638,5 +605,5 @@ def jsnHandle(action, resp, dataDict, instanceId='') -> dict:
638605
self.logger.info('Sending pushNotification_event')
639606
await connection.send(dumps(jsn))
640607

641-
else:
642-
self.logger.info(Trace + ' not found!')
608+
#else:
609+
# self.logger.info(Trace + ' not found!')

sinric/_sinricpro.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,13 @@ async def connect(self, udp_client=None, sleep=0):
5353
self.connection = await self.socket.connect()
5454
receive_message_task = asyncio.create_task(self.socket.receiveMessage(connection=self.connection))
5555
handle_queue_task = asyncio.create_task(self.socket.handleQueue())
56-
handle_event_queue_task = asyncio.create_task(self.event_callbacks())
56+
5757
await receive_message_task
5858
await handle_queue_task
59-
await handle_event_queue_task
59+
60+
if self.event_callbacks is not None:
61+
handle_event_queue_task = asyncio.create_task(self.event_callbacks())
62+
await handle_event_queue_task
6063

6164
except KeyboardInterrupt:
6265
self.logger.error('Keyboard interrupt')

0 commit comments

Comments
 (0)