Merged
Conversation
namesty
requested review from
Niraj-Kamdar,
cbrzn,
dOrgJelli,
krisbitney and
nerfZael
as code owners
nerfZael
approved these changes
Jun 15, 2023
dOrgJelli
approved these changes
Jun 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for polywrap/rust-wrap-client#59
In Rust,
bytesand an array of uint8 are not different types, they're all justVec<u8>. But in the msgpack specification, they are indeed different (seebinfamily). Therefore, when deserializing abinmsgpack type and trying to coerce it toVec<u8>, a mismatch error gets thrown (3Hren/msgpack-rust#249).This PR adds annotations to use serde_bytes serialization/deserialization as recommended in the
rmp_serdeissue thread.