Skip to content

Commit 0db90bc

Browse files
mathiasbynensCommit Bot
authored andcommitted
[regexp] Include unicode/uvernum.h in parser
This patch explicitly includes unicode/uvernum.h in the regular expression parser. It should be removed once we no longer need to check `U_ICU_VERSION_MAJOR_NUM` during preprocessing, i.e. once Node.js updates their ICU. This is an ongoing effort: nodejs/node#16876 BUG=v8:4743 Change-Id: I3cd9447b481249a9035d9fb00745057da8809c58 Reviewed-on: https://chromium-review.googlesource.com/758407 Reviewed-by: Jakob Gruber <[email protected]> Reviewed-by: Yang Guo <[email protected]> Commit-Queue: Mathias Bynens <[email protected]> Cr-Commit-Position: refs/heads/master@{#49253}
1 parent de65d40 commit 0db90bc

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

src/regexp/regexp-parser.cc

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,10 @@
1414
#include "src/regexp/jsregexp.h"
1515
#include "src/utils.h"
1616

17+
// TODO(mathias): Remove this when we no longer need to check
18+
// `U_ICU_VERSION_MAJOR_NUM`.
19+
#include "unicode/uvernum.h"
20+
1721
#ifdef V8_INTL_SUPPORT
1822
#include "unicode/uniset.h"
1923
#endif // V8_INTL_SUPPORT

0 commit comments

Comments
 (0)