fix(#3248): bookmark filter shows contents of marked directories#3249
Merged
alex-courtis merged 1 commit intonvim-tree:masterfrom Jan 23, 2026
Merged
fix(#3248): bookmark filter shows contents of marked directories#3249alex-courtis merged 1 commit intonvim-tree:masterfrom
alex-courtis merged 1 commit intonvim-tree:masterfrom
Conversation
| @@ -134,6 +134,9 @@ function Filters:bookmark(path, path_type, bookmarks) | |||
|
|
|||
| local mark_parent = utils.path_add_trailing(path) | |||
| for mark, mark_type in pairs(bookmarks) do | |||
Member
There was a problem hiding this comment.
Those variable names are quite misleading; mark is a path and mark_type is the actual bookmark. Not sure how that ever worked.
Tested OK
Collaborator
Author
There was a problem hiding this comment.
ok let me update the var name
Member
There was a problem hiding this comment.
Don't stress, it's well outside of the scope of a bugfix.
Collaborator
Author
There was a problem hiding this comment.
I will raise another PR to update the variable name. This will make things smaller and easier to review.
Member
There was a problem hiding this comment.
Thanks @xiantang I really appreciate the extra effort.
Collaborator
Author
There was a problem hiding this comment.
alex-courtis
approved these changes
Jan 23, 2026
Member
alex-courtis
left a comment
alex-courtis
left a comment
There was a problem hiding this comment.
Tested OK with user's test cases. Many thanks for the quick resolution!
alex-courtis
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #3248