Draft: more IPv6 fixes

Author: treysis

test/common/inspector-helper.js

@@ -364,7 +364,7 @@ class NodeInstance extends EventEmitter {
 
   static async startViaSignal(scriptContents) {
     const instance = new NodeInstance(
-      ['--expose-internals'],
+      ['--inspect=localhost', '--expose-internals'],
       `${scriptContents}\nprocess._rawDebug('started');`, undefined);
     const msg = 'Timed out waiting for process to start';
     while (await fires(instance.nextStderrString(), msg, TIMEOUT) !==

test/parallel/test-http-localaddress.js

@@ -44,7 +44,7 @@ server.listen(0, 'localhost', () => {
                     port: server.address().port,
                     path: '/',
                     method: 'GET',
-                    localAddress: 'localhost' };
+                    localAddress: '::1' };
 
   const req = http.request(options, function(res) {
     res.on('end', () => {

test/parallel/test-http2-connect-options.js

@@ -25,7 +25,7 @@ server.listen(0, 'localhost', common.mustCall(() => {
   const options = { localAddress: 'localhost' };
 
   const client = http2.connect(
-    'http://localhost:' + server.address().port,
+    'http://[::1]:' + server.address().port,
     options
   );
   const req = client.request({

test/parallel/test-https-localaddress.js

@@ -54,7 +54,7 @@ server.listen(0, 'localhost', function() {
     port: this.address().port,
     path: '/',
     method: 'GET',
-    localAddress: 'localhost',
+    localAddress: '::1',
     rejectUnauthorized: false
   };
 

test/parallel/test-inspect-async-hook-setup-at-inspect.js

@@ -45,7 +45,7 @@ async function checkAsyncStackTrace(session) {
 }
 
 async function runTests() {
-  const instance = new NodeInstance(['--inspect=::1'], script);
+  const instance = new NodeInstance(['--inspect=localhost'], script);
   const session = await instance.connectInspectorSession();
   await session.send([
     { 'method': 'Runtime.enable' },

test/parallel/test-inspect-publish-uid.js

@@ -18,7 +18,7 @@ async function testArg(argValue) {
   const hasStderr = argValue.split(',').includes('stderr');
 
   const nodeProcess = spawnSync(process.execPath, [
-    '--inspect=0',
+    '--inspect=localhost:0',
     `--inspect-publish-uid=${argValue}`,
     '-e', `(${scriptMain.toString()})(${hasHttp ? 200 : 404})`
   ]);

test/parallel/test-inspector-waiting-for-disconnect.js

@@ -12,7 +12,7 @@ function mainContextDestroyed(notification) {
 }
 
 async function runTest() {
-  const child = new NodeInstance(['--inspect-brk=0', '-e', 'process.exit(55)']);
+  const child = new NodeInstance(['--inspect-brk=localhost:0', '-e', 'process.exit(55)']);
   const session = await child.connectInspectorSession();
   const oldStyleSession = await child.connectInspectorSession();
   await oldStyleSession.send([

test/parallel/test-tcp-wrap-connect.js

@@ -14,7 +14,7 @@ function makeConnection() {
   const client = new TCP(TCPConstants.SOCKET);
 
   const req = new TCPConnectWrap();
-  const err = client.connect(req, '127.0.0.1', this.address().port);
+  const err = client.connect(req, '::1', this.address().port);
   assert.strictEqual(err, 0);
 
   req.oncomplete = function(status, client_, req_, readable, writable) {

test/parallel/test-tcp-wrap-listen.js

@@ -14,7 +14,7 @@ const {
 
 const server = new TCP(TCPConstants.SOCKET);
 
-const r = server.bind('0.0.0.0', 0);
+const r = server.bind('::1', 0);
 assert.strictEqual(r, 0);
 let port = {};
 server.getsockname(port);

test/sequential/test-https-connect-localport.js

@@ -17,10 +17,10 @@ const assert = require('assert');
     res.end();
   }));
 
-  server.listen(0, 'localhost', common.mustCall(() => {
+  server.listen(0, '::1', common.mustCall(() => {
     const port = server.address().port;
     const req = https.get({
-      host: 'localhost',
+      host: '::1',
       pathname: '/',
       port,
       family: 4,