Skip to content

Commit 9bdc12a

Browse files
benjamingrMyles Borins
authored andcommitted
dns: use template literals
Prefer the use of template string literals over string concatenation in the dns module, makes dns consistent with other modules basically doing #5778 for it. PR-URL: #5809 Reviewed-By: James M Snell <[email protected]>
1 parent aaf4dbc commit 9bdc12a

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

lib/dns.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,8 @@ function errnoException(err, syscall, hostname) {
2323
}
2424
var ex = null;
2525
if (typeof err === 'string') { // c-ares error code.
26-
ex = new Error(syscall + ' ' + err + (hostname ? ' ' + hostname : ''));
26+
const errHost = hostname ? ' ' + hostname : '';
27+
ex = new Error(`${syscall} ${err}${errHost}`);
2728
ex.code = err;
2829
ex.errno = err;
2930
ex.syscall = syscall;
@@ -268,7 +269,7 @@ exports.resolve = function(hostname, type_, callback_) {
268269
if (typeof resolver === 'function') {
269270
return resolver(hostname, callback);
270271
} else {
271-
throw new Error('Unknown type "' + type_ + '"');
272+
throw new Error(`Unknown type "${type_}"`);
272273
}
273274
};
274275

@@ -306,7 +307,7 @@ exports.setServers = function(servers) {
306307
if (ver)
307308
return newSet.push([ver, s]);
308309

309-
throw new Error('IP address is not properly formatted: ' + serv);
310+
throw new Error(`IP address is not properly formatted: ${serv}`);
310311
});
311312

312313
var r = cares.setServers(newSet);
@@ -316,8 +317,7 @@ exports.setServers = function(servers) {
316317
cares.setServers(orig.join(','));
317318

318319
var err = cares.strerror(r);
319-
throw new Error('c-ares failed to set servers: "' + err +
320-
'" [' + servers + ']');
320+
throw new Error(`c-ares failed to set servers: "${err}" [${servers}]`);
321321
}
322322
};
323323

0 commit comments

Comments
 (0)