lib: remove multiple noop definition

Define `noop` in `internal/util`. And use it elsewhere.

Author: deokjinkim

lib/_http_server.js

@@ -80,6 +80,7 @@ const {
 } = codes;
 const {
   kEmptyObject,
+  noop,
 } = require('internal/util');
 const {
   validateInteger,
@@ -809,7 +810,6 @@ function onParserTimeout(server, socket) {
     socket.destroy();
 }
 
-const noop = () => {};
 const badRequestResponse = Buffer.from(
   `HTTP/1.1 400 ${STATUS_CODES[400]}\r\n` +
   'Connection: close\r\n\r\n', 'ascii',

lib/_tls_wrap.js

@@ -25,7 +25,6 @@ const {
   ArrayPrototypeForEach,
   ArrayPrototypeJoin,
   ArrayPrototypePush,
-  FunctionPrototype,
   ObjectAssign,
   ObjectDefineProperty,
   ObjectSetPrototypeOf,
@@ -43,6 +42,7 @@ const {
   assertCrypto,
   deprecate,
   kEmptyObject,
+  noop,
 } = require('internal/util');
 
 assertCrypto();
@@ -114,8 +114,6 @@ const kPskIdentityHint = Symbol('pskidentityhint');
 const kPendingSession = Symbol('pendingSession');
 const kIsVerified = Symbol('verified');
 
-const noop = FunctionPrototype;
-
 let ipServernameWarned = false;
 let tlsTracingWarned = false;
 

lib/internal/assert/calltracker.js

@@ -4,7 +4,6 @@ const {
   ArrayPrototypePush,
   ArrayPrototypeSlice,
   Error,
-  FunctionPrototype,
   ObjectFreeze,
   Proxy,
   ReflectApply,
@@ -19,12 +18,11 @@ const {
   },
 } = require('internal/errors');
 const AssertionError = require('internal/assert/assertion_error');
+const { noop } = require('internal/util');
 const {
   validateUint32,
 } = require('internal/validators');
 
-const noop = FunctionPrototype;
-
 class CallTrackerContext {
   #expected;
   #calls;

lib/internal/cluster/child.js

@@ -2,7 +2,6 @@
 
 const {
   ArrayPrototypeJoin,
-  FunctionPrototype,
   ObjectAssign,
   ReflectApply,
   SafeMap,
@@ -17,12 +16,12 @@ const Worker = require('internal/cluster/worker');
 const { internal, sendHelper } = require('internal/cluster/utils');
 const { exitCodes: { kNoFailure } } = internalBinding('errors');
 const { TIMEOUT_MAX } = require('internal/timers');
+const { noop } = require('internal/util');
 const { setInterval, clearInterval } = require('timers');
 
 const cluster = new EventEmitter();
 const handles = new SafeMap();
 const indexes = new SafeMap();
-const noop = FunctionPrototype;
 
 module.exports = cluster;
 

lib/internal/modules/esm/module_job.js

@@ -4,7 +4,6 @@ const {
   ArrayPrototypeJoin,
   ArrayPrototypePush,
   ArrayPrototypeSome,
-  FunctionPrototype,
   ObjectSetPrototypeOf,
   PromiseResolve,
   PromisePrototypeThen,
@@ -21,15 +20,16 @@ const {
 
 const { ModuleWrap } = internalBinding('module_wrap');
 
-const { decorateErrorStack } = require('internal/util');
+const {
+  decorateErrorStack,
+  noop,
+} = require('internal/util');
 const {
   getSourceMapsEnabled,
 } = require('internal/source_map/source_map_cache');
 const assert = require('internal/assert');
 const resolvedPromise = PromiseResolve();
 
-const noop = FunctionPrototype;
-
 let hasPausedEntry = false;
 
 const CJSGlobalLike = [

lib/internal/repl/await.js

@@ -6,7 +6,6 @@ const {
   ArrayPrototypeJoin,
   ArrayPrototypePop,
   ArrayPrototypePush,
-  FunctionPrototype,
   ObjectKeys,
   RegExpPrototypeSymbolReplace,
   StringPrototypeEndsWith,
@@ -21,12 +20,12 @@ const {
 const parser = require('internal/deps/acorn/acorn/dist/acorn').Parser;
 const walk = require('internal/deps/acorn/acorn-walk/dist/walk');
 const { Recoverable } = require('internal/repl');
+const { noop } = require('internal/util');
 
 function isTopLevelDeclaration(state) {
   return state.ancestors[state.ancestors.length - 2] === state.body;
 }
 
-const noop = FunctionPrototype;
 const visitorsWithoutAncestors = {
   ClassDeclaration(node, state, c) {
     if (isTopLevelDeclaration(state)) {

lib/internal/repl/history.js

@@ -3,7 +3,6 @@
 const {
   ArrayPrototypeJoin,
   Boolean,
-  FunctionPrototype,
   RegExpPrototypeSymbolSplit,
   StringPrototypeTrim,
 } = primordials;
@@ -16,10 +15,9 @@ let debug = require('internal/util/debuglog').debuglog('repl', (fn) => {
   debug = fn;
 });
 const permission = require('internal/process/permission');
+const { noop } = require('internal/util');
 const { clearTimeout, setTimeout } = require('timers');
 
-const noop = FunctionPrototype;
-
 // XXX(chrisdickinson): The 15ms debounce value is somewhat arbitrary.
 // The debounce is to guard against code pasted into the REPL.
 const kDebounceHistoryMS = 15;

lib/internal/test_runner/test.js

@@ -6,7 +6,6 @@ const {
   ArrayPrototypeSlice,
   ArrayPrototypeSome,
   ArrayPrototypeUnshift,
-  FunctionPrototype,
   MathMax,
   Number,
   ObjectSeal,
@@ -41,6 +40,7 @@ const {
 const {
   createDeferredPromise,
   kEmptyObject,
+  noop,
   once: runOnce,
 } = require('internal/util');
 const { isPromise } = require('internal/util/types');
@@ -63,7 +63,6 @@ const kTestCodeFailure = 'testCodeFailure';
 const kTestTimeoutFailure = 'testTimeoutFailure';
 const kHookFailure = 'hookFailed';
 const kDefaultTimeout = null;
-const noop = FunctionPrototype;
 const kShouldAbort = Symbol('kShouldAbort');
 const kFilename = process.argv?.[1];
 const kHookNames = ObjectSeal(['before', 'after', 'beforeEach', 'afterEach']);

lib/internal/util.js

@@ -8,6 +8,7 @@ const {
   ArrayPrototypeSlice,
   ArrayPrototypeSort,
   Error,
+  FunctionPrototype,
   FunctionPrototypeCall,
   ObjectDefineProperties,
   ObjectDefineProperty,
@@ -65,6 +66,8 @@ const { isNativeError } = internalBinding('types');
 
 const noCrypto = !process.versions.openssl;
 
+const noop = FunctionPrototype;
+
 const experimentalWarnings = new SafeSet();
 
 const colorRegExp = /\u001b\[\d\d?m/g; // eslint-disable-line no-control-regex
@@ -777,6 +780,7 @@ module.exports = {
   join,
   lazyDOMException,
   lazyDOMExceptionClass,
+  noop,
   normalizeEncoding,
   once,
   promisify,

lib/internal/util/debuglog.js

@@ -9,6 +9,7 @@ const {
   StringPrototypeToUpperCase,
 } = primordials;
 
+const { noop } = require('internal/util');
 const { inspect, format, formatWithOptions } = require('internal/util/inspect');
 
 // `debugImpls` and `testEnabled` are deliberately not initialized so any call
@@ -43,8 +44,6 @@ function emitWarningIfNeeded(set) {
   }
 }
 
-const noop = () => {};
-
 function debuglogImpl(enabled, set) {
   if (debugImpls[set] === undefined) {
     if (enabled) {